From: Greg KH <greg@kroah.com>
To: Ben Collins <bcollins@ubuntu.com>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [Updated v3]: How to become a kernel driver maintainer
Date: Fri, 2 Jun 2006 17:03:17 -0700 [thread overview]
Message-ID: <20060603000317.GA10037@kroah.com> (raw)
In-Reply-To: <1149284317.4533.312.camel@grayson>
On Fri, Jun 02, 2006 at 05:38:36PM -0400, Ben Collins wrote:
> The real work of maintainership begins after your code is in the tree.
> This is where some maintainers fail, and is the reason the kernel
> developers are so reluctant to allow new drivers into the main tree.
I don't think this is true. On-going maintenance of a driver is quite
minor over time, unless you are adding new support, or if there are bugs
in your driver. We will gladly accept any driver, as long as it follows
the proper coding style rules and plays nice with the rest of the
kernel.
> The other side of the coin is keeping changes in the kernel synced to your
> code. Often times, it is necessary to change a kernel API (driver model,
> USB stack changes, networking subsystem change, etc). These sorts of
> changes usually affect a large number of drivers. It is not feasible for
> these changes to be individually submitted to the driver maintainers. So
> instead, the changes are made together in the kernel tree. If your driver
> is affected, you are expected to pick up these changes and merge them with
> your temporary development copy. Usually this job is made easier if you
> use the same source control system that the kernel maintainers use
> (currently, git), but this is not required. Using git, however, allows you
> to merge more easily.
Almost always, the person doing the API change fixes all in-kernel
versions of the api change. So the driver author/maintainer does not
have to fix up anything.
>
> There are times where changes to your driver may happen that are not the
> API type of changes described above. A user of your driver may submit a
> patch directly to Linus to fix an obvious bug in the code. Sometimes these
> trivial and obvious patches will be accepted without feedback from the
> driver maintainer. Don't take this personally. We're all in this together.
> Just pick up the change and keep in sync with it. If you think the change
> was incorrect, try to find the mailing list thread or log comments
> regarding the change to see what was going on. Then email the patch author
> about the change to start discussion.
>
>
> How should I maintain my code after it's in the kernel tree?
> ------------------------------------------------------------
>
> The suggested, and certainly the easiest method, is to start a git tree
> cloned from the primary kernel tree. In this way, you are able to
> automatically track the kernel changes by pulling from Linus' tree. You
> can read more about maintaining a kernel git tree at
> http://linux.yyz.us/git-howto.html.
I disagree, quilt is _much_ easier for maintaining patches against a
common tree. Combined with ketchup and it makes things dirt simple.
Everything else looks good, very nice job.
thanks,
greg k-h
next prev parent reply other threads:[~2006-06-03 0:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 16:07 [PATCH]: How to be a kernel driver maintainer Ben Collins
2006-01-08 16:33 ` Arjan van de Ven
2006-01-08 18:27 ` Ben Collins
2006-01-08 18:43 ` Arjan van de Ven
2006-01-08 18:57 ` Arjan van de Ven
2006-01-09 9:51 ` Joel Becker
2006-01-08 21:45 ` [PATCH updated]: " Ben Collins
2006-01-09 7:46 ` Arjan van de Ven
2006-01-09 13:34 ` Ben Collins
2006-01-09 14:02 ` Grant Coady
2006-01-09 21:28 ` Arjan van de Ven
2006-01-10 0:09 ` Linus Torvalds
2006-01-10 0:58 ` Ben Collins
2006-03-08 18:03 ` [Updated]: How to become " Ben Collins
2006-03-08 19:05 ` Jesper Juhl
2006-03-08 19:10 ` Arjan van de Ven
2006-03-08 19:27 ` Jesper Juhl
2006-06-02 21:38 ` [Updated v3]: " Ben Collins
2006-06-02 22:16 ` Randy.Dunlap
2006-06-03 0:03 ` Greg KH [this message]
2006-06-05 10:27 ` Jan Engelhardt
2006-03-09 4:32 ` [Updated]: " Randy.Dunlap
2006-01-08 21:47 ` [PATCH]: How to be " Ben Collins
2006-01-09 19:26 ` Pavel Machek
2006-01-10 15:10 ` Ben Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060603000317.GA10037@kroah.com \
--to=greg@kroah.com \
--cc=bcollins@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.