All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] PATCH: hwmon-abituguru-nofans-detect-fix.patch
Date: Sun, 04 Jun 2006 15:45:41 +0000	[thread overview]
Message-ID: <20060604174541.9614e93f.khali@linux-fr.org> (raw)
In-Reply-To: <4482F184.1040006@hhs.nl>

Hi Hans,

> One of my testers had a problem where the driver only saw 2 of the 4 fan
> sensors his uGuru has, this fixes this:
> -accept 0x40 (bit 6) being high as a valid fan sensor setting for all
>  fans not just fan 1, I have a feeling this bit indicates whether or not
>  a fan is actually connected .
> 
> Signed-off-by: Hans de Goede <j.w.r.degoede at hhs.nl>

Applied, thanks.

> Well this is the first small fix to the uGuru driver I hope it will also
> be the last for atleast a couple of days. If this becomes a daily
> business (which I don't expect it to become) its probably the best to
> bundle fixes and send a patch once a week or do you prefer many small
> patches?

I told you this would happen, remember ;)

I'm totally fine with small patches, they're easier to review, revert
and/or backport.

-- 
Jean Delvare


      reply	other threads:[~2006-06-04 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-04 14:43 [lm-sensors] PATCH: hwmon-abituguru-nofans-detect-fix.patch Hans de Goede
2006-06-04 15:45 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060604174541.9614e93f.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.