Re: [PATCH] Hardware P-state driver for AMD Opterons, etc.

[Dave Jones <davej@redhat.com>]

On Sun, Jun 04, 2006 at 07:18:40PM +0200, Dominik Brodowski wrote:
 > Hi,
 > 
 > On Fri, Jun 02, 2006 at 05:45:24PM -0500, Langsdorf, Mark wrote:
 > > +static int cpu_family = CPU_OPTERON;
 > 
 > ...
 > 
 > > +	if (cpu_family)
 > > +		return 0;
 > > +
 > 
 > ...
 > 
 > > +	if (cpu_family) {
 > > +		rdmsr(MSR_PSTATE_STATUS, lo, hi);
 > 
 > ...
 > 
 > I'd prefer it if all these if cases would be made explicit:
 > 
 > 
 > 	if (cpu_family == CPU_OPTERON)
 > 
 > as that makes the code much more readable.

I'll second that, but I'll prefer that as a separate diff
as I've already started cleaning up the whitespace damage
in the previous diff, so I'll apply that in a few minutes.

Mark, your editor seems to use a mix of spaces and tabs, which
looks really strange. I've fixed up the few cases that stood out,
so you may want to base your next diff on what turns up in -mm4
when Andrew releases that tree.

		Dave

-- 
http://www.codemonkey.org.uk