From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] [PATCH 2.6] cleanup of i2c-nforce2,
Date: Mon, 05 Jun 2006 07:00:23 +0000 [thread overview]
Message-ID: <20060605090023.647b87ee.khali@linux-fr.org> (raw)
In-Reply-To: <200512270102.30671.hfvogt@gmx.net>
Hallo Hans-Frider,
> I invested a little bit of time into the nforce2/3/4 SMBus driver and changed
> the following things:
>
> - general cleanup:
> o removed code for the unsupported I2C block transfer mode
> o removed detail warnings about unsupported modes that are covered in a
> general warning (unsupported transaction...) anyway
> o removed necessity of a definition of struct i2c_adapter
> o moved definition of struct i2c_algorithm, making forward declarations of
> nforce2_access and nforce2_func unnecessary
> - improvements:
> o support MCP51 and MCP55 southbridges
> o advertise I2C_FUNC_SMBUS_BLOCK_DATA, so that it really can be used
>
> the patch is relative to 2.6.15-rc7 with your patch
> i2c-nforce2-support-nforce4-mcp04.patch of 18 december (thanks) already
> applied. If preferred, I can of course also send a full patch relative to
> 2.6.15-rc7 (which should be applicable to other kernel versions as well).
I'm sorry for overlooking this patch when you sent it back in December
2005. Now we happen to have a part of these changes already merged in
the i2c-nforce2 driver (in particular support for the MPC51 and MPC55.)
Would you be kind enough to respin your cleanups on top the i2c-nforce2
driver as it exists in recent -mm tree? (Or on top of Linus' latest +
http://khali.linux-fr.org/devel/i2c/linux-2.6/i2c-nforce2-add-mcp51-mcp55-support.patch,
at your option.)
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2006-06-05 7:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-27 0:02 [lm-sensors] [PATCH 2.6] cleanup of i2c-nforce2, Hans-Frieder Vogt
2006-06-05 7:00 ` Jean Delvare [this message]
2006-06-07 22:09 ` Hans-Frieder Vogt
2006-06-08 8:27 ` Jean Delvare
2006-06-08 20:06 ` Hans-Frieder Vogt
2006-06-08 21:19 ` Jean Delvare
2006-06-08 22:09 ` Hans-Frieder Vogt
2006-06-11 11:28 ` Jean Delvare
2006-06-14 22:19 ` Hans-Frieder Vogt
2006-06-15 8:03 ` Jean Delvare
2006-06-15 8:11 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605090023.647b87ee.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.