From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] an error when compile lm_sensors2
Date: Mon, 05 Jun 2006 07:57:13 +0000 [thread overview]
Message-ID: <20060605095713.9ab529ea.khali@linux-fr.org> (raw)
In-Reply-To: <4483D5CE.40801@winbond.com>
Hi Yuan,
> When i compile lm_sensors2 on kernel 2.4 i met a error
>
> kernel/busses/i2c-viapro.c: In function `vt596_probe':
> kernel/busses/i2c-viapro.c:398: `PCI_DEVICE_ID_VIA_8237' undeclared (first use in this function)
> kernel/busses/i2c-viapro.c:398: (Each undeclared identifier is reported only once
> kernel/busses/i2c-viapro.c:398: for each function it appears in.)
> make: *** [kernel/busses/i2c-viapro.o] Error 1
>
> I just copy the definition of PCI_DEVICE_ID_VIA_8237 above function vt596_probe to skip this error.
> did i missing some configure?
Good catch. We know that old kernels don't have these defines and we
redefine the values ourselves when needed, however improvements I made
to the i2c-viapro driver some times ago make use of the values _before_
they are defined. I've moved the defines at the top of the source file,
this should fix the issue.
Thanks for reporting!
--
Jean Delvare
prev parent reply other threads:[~2006-06-05 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 6:57 [lm-sensors] an error when compile lm_sensors2 Yuan Mu
2006-06-05 7:57 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605095713.9ab529ea.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.