From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FnFbp-0003J8-UP for qemu-devel@nongnu.org; Mon, 05 Jun 2006 09:59:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FnFbm-0003Ib-Pd for qemu-devel@nongnu.org; Mon, 05 Jun 2006 09:59:08 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FnFbm-0003IY-M4 for qemu-devel@nongnu.org; Mon, 05 Jun 2006 09:59:06 -0400 Received: from [81.103.221.47] (helo=mtaout01-winn.ispmail.ntl.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FnFiw-0006oU-1i for qemu-devel@nongnu.org; Mon, 05 Jun 2006 10:06:30 -0400 Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout01-winn.ispmail.ntl.com with ESMTP id <20060605135902.IYGO29343.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Mon, 5 Jun 2006 14:59:02 +0100 Received: from miranda.arrow ([213.107.21.212]) by aamtaout01-winn.ispmail.ntl.com with ESMTP id <20060605135902.XQXB19763.aamtaout01-winn.ispmail.ntl.com@miranda.arrow> for ; Mon, 5 Jun 2006 14:59:02 +0100 Received: from sdb by miranda.arrow with local (Exim 4.50) id 1FnFh3-0004ri-LP for qemu-devel@nongnu.org; Mon, 05 Jun 2006 15:04:33 +0100 Date: Mon, 5 Jun 2006 15:04:33 +0100 From: Stuart Brady Message-ID: <20060605140433.GA18691@miranda.arrow> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="r5Pyd7+fXNt84Ff3" Content-Disposition: inline Subject: [Qemu-devel] Typo in get_reloc_expr (dyngen.c) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, There's a small bug in get_reloc_expr in dyngen.c. It should only affect SPARC hosts, but it can't be causing any real problems, or someone would have noticed it by now. I'm trying to port QEMU to PA-RISC[0], and needed this code, so it did actually affect me. I've attached the (one-line) patch. -- Stuart Brady [0] http://homepage.ntlworld.com/wholehog/stuart/qemu/guest.html --r5Pyd7+fXNt84Ff3 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="dyngen-fix.diff" diff -ur qemu-head/dyngen.c qemu-new/dyngen.c --- qemu-head/dyngen.c 2006-06-05 14:37:00.000000000 +0100 +++ qemu-new/dyngen.c 2006-06-05 14:36:49.000000000 +0100 @@ -1196,7 +1196,7 @@ } else { #ifdef HOST_SPARC if (sym_name[0] == '.') - snprintf(name, sizeof(name), + snprintf(name, name_size, "(long)(&__dot_%s)", sym_name + 1); else --r5Pyd7+fXNt84Ff3--