From: Stephen Hemminger <shemminger@osdl.org>
To: "Michael Chan" <mchan@broadcom.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX
Date: Mon, 5 Jun 2006 17:31:59 -0700 [thread overview]
Message-ID: <20060605173159.33d81d59@localhost.localdomain> (raw)
In-Reply-To: <1149542985.13155.11.camel@rh4>
On Mon, 05 Jun 2006 14:29:45 -0700
"Michael Chan" <mchan@broadcom.com> wrote:
> On Mon, 2006-06-05 at 15:58 -0700, Stephen Hemminger wrote:
>
> >
> > Since you are going more lockless, you probably need memory barriers.
>
> No, we're not going more lockless. We're simply replacing the private
> tx_lock with dev->xmit_lock by dropping the LLTX feature flag. The
> amount of locking is exactly the same as before.
Those spin lock's were also acting as barriers.
Are you sure code is safe in the face of cpu reordering.
--
If one would give me six lines written by the hand of the most honest
man, I would find something in them to have him hanged. -- Cardinal Richlieu
next prev parent reply other threads:[~2006-06-06 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 19:47 [PATCH 2.6.18 2/3] tg3: Convert to non-LLTX Michael Chan
2006-06-05 22:58 ` Stephen Hemminger
2006-06-05 21:29 ` Michael Chan
2006-06-06 0:31 ` Stephen Hemminger [this message]
2006-06-05 23:34 ` Michael Chan
2006-06-05 23:06 ` David Miller
2006-06-18 4:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605173159.33d81d59@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.