All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Belay <ambx1@neo.rr.com>
To: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@osdl.org>, Ryan Lortie <desrt@desrt.ca>,
	linux-kernel@vger.kernel.org, mjg59@srcf.ucam.org,
	bcollins@ubuntu.com, Greg KH <greg@kroah.com>
Subject: Re: pci_restore_state
Date: Mon, 5 Jun 2006 14:42:05 -0400	[thread overview]
Message-ID: <20060605184204.GA7534@neo.rr.com> (raw)
In-Reply-To: <17538.49656.797376.483713@cargo.ozlabs.ibm.com>

On Sun, Jun 04, 2006 at 09:20:24PM +1000, Paul Mackerras wrote:
> Andrew Morton writes:
> 
> > On Sun, 04 Jun 2006 06:13:30 -0400
> > Ryan Lortie <desrt@desrt.ca> wrote:
> > > If I reverse the for loop to start from 15 and count down to 0, then the
> > > majority of the configuration space is filled in _before_ the command
> > > word is modified.  No crash.
> > 
> > We have a patch pending which will do that.
> > 
> > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-03-pci/pci-reverse-pci-config-space-restore-order.patch
> 
> We really shouldn't be writing to the BIST register, at least...
> 
> Also, I don't quite see the point of writing to the read-only
> registers such as vendor and device ID.
> 
> Paul.

Any comments on this patch as an alternative solution?

http://marc.theaimsgroup.com/?l=linux-kernel&m=114949711413176&w=2

Thanks,
Adam

      reply	other threads:[~2006-06-05 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-04 10:13 pci_restore_state Ryan Lortie
2006-06-04 10:27 ` pci_restore_state Andrew Morton
2006-06-04 11:20   ` pci_restore_state Paul Mackerras
2006-06-05 18:42     ` Adam Belay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060605184204.GA7534@neo.rr.com \
    --to=ambx1@neo.rr.com \
    --cc=akpm@osdl.org \
    --cc=bcollins@ubuntu.com \
    --cc=desrt@desrt.ca \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.