From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Andrew Morton <akpm@osdl.org>, davem@caip.rutgers.edu
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
nickpiggin@yahoo.com.au, mingo@elte.hu, pwil3058@bigpond.net.au,
linux-kernel@vger.kernel.org
Subject: Re: [Patch] sched: mc/smt power savings sched policy
Date: Wed, 7 Jun 2006 10:29:17 -0700 [thread overview]
Message-ID: <20060607102917.A25186@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060607094943.0433a52c.akpm@osdl.org>; from akpm@osdl.org on Wed, Jun 07, 2006 at 09:49:43AM -0700
On Wed, Jun 07, 2006 at 09:49:43AM -0700, Andrew Morton wrote:
> On Tue, 6 Jun 2006 11:25:21 -0700
> "Siddha, Suresh B" <suresh.b.siddha@intel.com> wrote:
>
> > Appended the patch. Can someone please test compile the powerpc change?
>
> powerpc compiles and boots OK, but sparc64 is not so good.
>
> kernel/built-in.o(.text+0x6ec0): In function `sched_create_sysfs_power_savings_entries':
> : undefined reference to `smt_capable'
Dave, I am not sure if the appended patch is the correct(perhaps temporary?)
mechanism(currently smp_prepare_cpus() also uses this mechanism) in identifying
a SMT capable sparc64 processor. Can you confirm?
thanks,
suresh
--
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
--- linux-2.6.17-rc5/include/asm-sparc64/topology.h 2006-05-24 18:50:17.000000000 -0700
+++ linux/include/asm-sparc64/topology.h 2006-06-07 08:28:13.726071744 -0700
@@ -1,6 +1,9 @@
#ifndef _ASM_SPARC64_TOPOLOGY_H
#define _ASM_SPARC64_TOPOLOGY_H
+#include <asm/spitfire.h>
+#define smt_capable() (tlb_type == hypervisor)
+
#include <asm-generic/topology.h>
#endif /* _ASM_SPARC64_TOPOLOGY_H */
prev parent reply other threads:[~2006-06-07 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-06 18:25 [Patch] sched: mc/smt power savings sched policy Siddha, Suresh B
2006-06-06 23:59 ` Con Kolivas
2006-06-07 1:06 ` Siddha, Suresh B
2006-06-07 16:49 ` Andrew Morton
2006-06-07 17:29 ` Siddha, Suresh B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060607102917.A25186@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=akpm@osdl.org \
--cc=davem@caip.rutgers.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pwil3058@bigpond.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.