All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Linsys Contractor Amit S. Kale" <amitkale@unminc.com>
Cc: netdev@vger.kernel.org, sanjeev@netxen.com, unmproj@linsyssoft.com
Subject: Re: [PATCH 1/9] NetXen 1G/10G ethernet driver patch with corrections
Date: Wed, 7 Jun 2006 11:49:51 +0200	[thread overview]
Message-ID: <200606071149.51879.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0606070237220.10031@unmsrvr>

On Wednesday 07 June 2006 11:39, Linsys Contractor Amit S. Kale wrote:

> +	switch (mode) {

... You could save a lot of code by using a table and a loop over the registers.


> +	case 4:{		/* XGB Mode */
> +			NETXEN_NIC_LOCKED_READ_REG(NETXEN_NIU_XG_SINGLE_TERM,
> +						   &regs_buff[3]);


-Andi

  reply	other threads:[~2006-06-07  9:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-07  9:39 [PATCH 1/9] NetXen 1G/10G ethernet driver patch with corrections Linsys Contractor Amit S. Kale
2006-06-07  9:49 ` Andi Kleen [this message]
2006-06-08 14:55   ` Pradeep Dalvi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606071149.51879.ak@suse.de \
    --to=ak@suse.de \
    --cc=amitkale@unminc.com \
    --cc=netdev@vger.kernel.org \
    --cc=sanjeev@netxen.com \
    --cc=unmproj@linsyssoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.