From: Joachim Fritschi <jfritschi@freenet.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, ak@suse.de
Subject: Re: [PATCH 1/4] Twofish cipher - split out common c code
Date: Thu, 8 Jun 2006 09:20:04 +0200 [thread overview]
Message-ID: <200606080920.04480.jfritschi@freenet.de> (raw)
In-Reply-To: <20060608015728.GA8314@gondor.apana.org.au>
On Thursday 08 June 2006 03:57, Herbert Xu wrote:
> On Wed, Jun 07, 2006 at 09:37:23PM +0200, Joachim Fritschi wrote:
> >
> > diff -uprN linux-2.6.17-rc5/crypto/Makefile linux-2.6.17-rc5.twofish/crypto/Makefile
> > --- linux-2.6.17-rc5/crypto/Makefile 2006-06-07 18:43:24.000000000 +0200
> > +++ linux-2.6.17-rc5.twofish/crypto/Makefile 2006-06-04 13:59:27.949797218 +0200
> > @@ -32,3 +32,5 @@ obj-$(CONFIG_CRYPTO_MICHAEL_MIC) += mich
> > obj-$(CONFIG_CRYPTO_CRC32C) += crc32c.o
> >
> > obj-$(CONFIG_CRYPTO_TEST) += tcrypt.o
> > +
> > +twofish-objs := twofish_c.o twofish_common.o
>
> What do we gain by renaming twofish.c to twofish_c.c?
Solve the naming conflict when compiling. Seemed to me like it is impossible to create a
twofish.o out of twofish.o and twofish_common.o . And since having the original module name
seemed more important to me i changed the name. I didn't find any other way in documentation
of the kernel makefiles. I hope this isn't another newbie mistake. =)
-Joachim
next prev parent reply other threads:[~2006-06-08 7:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 13:16 [PATCH 1/4] Twofish cipher - split out common c code Joachim Fritschi
2006-06-07 19:37 ` Joachim Fritschi
2006-06-08 1:15 ` Andi Kleen
2006-06-08 1:57 ` Herbert Xu
2006-06-08 7:20 ` Joachim Fritschi [this message]
2006-06-08 7:27 ` Herbert Xu
2006-06-16 11:58 ` Joachim Fritschi
2006-06-18 11:31 ` Herbert Xu
2006-06-18 13:53 ` Roman Zippel
2006-06-19 6:18 ` Herbert Xu
2006-06-19 14:12 ` Joachim Fritschi
2006-06-20 10:26 ` Herbert Xu
2006-06-20 10:27 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606080920.04480.jfritschi@freenet.de \
--to=jfritschi@freenet.de \
--cc=ak@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.