From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Christoph Hellwig <hch@lst.de>,
jejb@SteelEye.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix up request buffer reference in various scsi drivers
Date: Thu, 8 Jun 2006 19:46:18 +0200 [thread overview]
Message-ID: <20060608174618.GA22826@lst.de> (raw)
In-Reply-To: <1149788401.3436.22.camel@mulgrave.il.steeleye.com>
On Thu, Jun 08, 2006 at 01:40:01PM -0400, James Bottomley wrote:
> On Sat, 2006-06-03 at 13:21 +0200, Christoph Hellwig wrote:
> > Various scsi drivers use scsi_cmnd.buffer and scsi_cmnd.bufflen in their
> > queuecommand functions. Those fields are internal storage for the
> > midlayer only and are used to restore the original payload after
> > request_buffer and request_bufflen have been overwritten for EH. Using
> > the buffer and bufflen fields means they do very broken things in error
> > handling.
>
> We probably need this too, don't we?
At this point both values are always the same. The patch I sent is just
driver fixes, all the core changes are in the second patch I sent out as
an rfc.
prev parent reply other threads:[~2006-06-08 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-03 11:21 [PATCH] fix up request buffer reference in various scsi drivers Christoph Hellwig
2006-06-08 11:37 ` Jeff Garzik
2006-06-08 13:01 ` Matthew Wilcox
2006-06-08 13:06 ` James Bottomley
2006-06-08 13:26 ` Jeff Garzik
2006-06-08 13:54 ` James Bottomley
2006-06-08 14:17 ` Jeff Garzik
2006-06-08 14:35 ` James Bottomley
2006-06-08 14:44 ` Jeff Garzik
2006-06-08 17:40 ` James Bottomley
2006-06-08 17:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060608174618.GA22826@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@SteelEye.com \
--cc=jejb@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.