From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FoSP5-0008K7-5y
	for qemu-devel@nongnu.org; Thu, 08 Jun 2006 17:50:59 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FoSP3-0008IM-JM
	for qemu-devel@nongnu.org; Thu, 08 Jun 2006 17:50:58 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FoSP3-0008ID-B1
	for qemu-devel@nongnu.org; Thu, 08 Jun 2006 17:50:57 -0400
Received: from [65.74.133.6] (helo=mail.codesourcery.com)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FoSWx-0000j9-Bn
	for qemu-devel@nongnu.org; Thu, 08 Jun 2006 17:59:07 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Recent patches for qemu block-cow.c etc breaks Win32
	build becaus e of fsync()
Date: Thu, 8 Jun 2006 22:50:53 +0100
References: <A69CFE5B2F49D91186C1000BCD9DBD03E2AA20@otausminexs.au.otis.com>
	<200606082217.48797.paul@codesourcery.com>
	<Pine.LNX.4.63.0606082336280.28873@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.63.0606082336280.28873@wbgn013.biozentrum.uni-wuerzburg.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200606082250.53790.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> > > Why not define it in config-host.mak like this:
> > >
> > > --- configure.old	2006-06-08 23:06:48.000000000 +0200
> > > +++ configure	2006-06-08 23:07:10.000000000 +0200
> > > @@ -102,6 +102,7 @@
> > >  ;;
> > >  MINGW32*)
> > >  mingw32="yes"
> > > +CFLAGS="-Dfsync=_commit"
> > >  ;;
> > >  FreeBSD)
> > >  bsd="yes"
> >
> > No. This is what header files are for.
>
> Yes, but MS did not provide fsync in header files ;-)

I mean you should add a #define in a header file somewhere (eg. vl.h where 
there are already similar things), not do it via a commandline option.

Paul