All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Paris <jim@jtan.com>
To: htejun@gmail.com
Cc: linux-ide@vger.kernel.org
Subject: libata-tj-stable success report, with minor patch
Date: Sun, 11 Jun 2006 22:23:58 -0400	[thread overview]
Message-ID: <20060612022358.GA29164@jim.sh> (raw)

Hello Tejun,

I recently purchased a Norco DS-1220[1] 12-bay SATA enclosure from
Newegg[2].  It comes with a sil3124-based PCI/X card and uses sil3726
port multipliers.  Ater unsuccesfully wrestling with buggy proprietry
drivers included in the box, I found your libata-tj-stable[3] patches
and applied them to 2.6.16.19.  With the minor fix below, it seems to
be working wonderfully.  Thank you!!

The enclosure takes 4 SATA connections.  Bays appear connected like this:
  ata1.00    = bay 5
  ata1.01-04 = bay 1-4
  ata2.00    = bay 10
  ata2.01-04 = bay 6-9
  ata3.00    = bay 11
  ata4.00    = bay 12

Your patches only detected the first 4 out of 5 ports on each PM.
To fix this, I made this (admittedly naïve) change:

--- drivers/scsi/libata-pm.orig	2006-06-11 21:01:28.000000000 -0400
+++ drivers/scsi/libata-pm.c	2006-06-11 21:03:57.000000000 -0400
@@ -324,7 +324,7 @@
 	 * it requires hardreset to resume PM links.
 	 */
 	if (vendor == 0x1095 && devid == 0x4726) {
-		*nr_ports -= 2;
+		*nr_ports -= 1;
 		*link_flags |= ATA_LFLAG_HRST_TO_RESUME;
 	}
 }

The patch is also available here[4], along with dmesg and lspci output.
With this, all 12 bays are working fine.  I also did some limited
hotplug testing and ran into no problems at all.  Again, thank you!

-jim

[1] http://www.norcotek.com/news.php?news_id=24
[2] http://www.newegg.com/Product/Product.asp?Item=N82E16816133001
[3] http://home-tj.org/wiki/index.php/Libata-tj-stable
[4] http://jim.sh/~jim/libata/

             reply	other threads:[~2006-06-12  2:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-12  2:23 Jim Paris [this message]
2006-06-12  3:39 ` libata-tj-stable success report, with minor patch Tejun Heo
2006-06-12  4:06   ` Jim Paris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060612022358.GA29164@jim.sh \
    --to=jim@jtan.com \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.