All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Komal Shah <komal_shah802003@yahoo.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: Add minimal OMAP2430 support
Date: Mon, 12 Jun 2006 09:07:46 -0700	[thread overview]
Message-ID: <20060612160745.GA5942@atomide.com> (raw)
In-Reply-To: <20060612064309.71669.qmail@web37904.mail.mud.yahoo.com>

* Komal Shah <komal_shah802003@yahoo.com> [060611 23:45]:
> --- Juha Yrjölä <juha.yrjola@solidboot.com> wrote:
> 
> > 
> > Exactly.  That's why I keep my read_reg/write_reg functions static. 
> > Usually I put even the register definitions to the .c file, since
> > other 
> > drivers shouldn't have any business modifying them directly anyway.
> > 
> 
> Have them static prcm_read/write_reg means, that clock.c and prcm.c
> should be merged, as clock.c is the heaviest user of PRCM/CM_*
> registers as of now, and only having static prcm_read/write_reg
> functions in prcm.c doesn't solve usage PRCM_* registers from clock.c?

Or put clock related PRCM registers to clock.c, power domain related
registers to pm-domain.c and so on. I have pm-domain.c somewhat ready
here and will push it as soon as I can.

Regards,

Tony

  reply	other threads:[~2006-06-12 16:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-11 13:22 [PATCH] ARM: OMAP: Add minimal OMAP2430 support Woodruff, Richard
2006-06-11 13:54 ` Juha Yrjölä
2006-06-12  6:43   ` Komal Shah
2006-06-12 16:07     ` Tony Lindgren [this message]
2006-06-12 16:35       ` Komal Shah
  -- strict thread matches above, loose matches on Subject: below --
2006-06-11 13:09 Woodruff, Richard
2006-06-11 12:15 Woodruff, Richard
2006-06-11 12:50 ` Juha Yrjölä
2006-05-21 13:50 Woodruff, Richard
2006-05-18 12:30 Woodruff, Richard
2006-05-21 12:23 ` Komal Shah
2006-05-18 11:44 Komal Shah
2006-06-05 16:54 ` Tony Lindgren
2006-06-06  3:08   ` Komal Shah
2006-06-06 17:58     ` Tony Lindgren
2006-06-11  8:37       ` Komal Shah
2006-06-11 10:08         ` Juha Yrjölä
2006-05-17 10:50 Komal Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060612160745.GA5942@atomide.com \
    --to=tony@atomide.com \
    --cc=komal_shah802003@yahoo.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.