From: Michael Buesch <mb@bu3sch.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 built-in command line
Date: Mon, 12 Jun 2006 19:36:34 +0200 [thread overview]
Message-ID: <200606121936.35042.mb@bu3sch.de> (raw)
In-Reply-To: <e6k7ak$gpd$1@terminus.zytor.com>
On Monday 12 June 2006 19:12, H. Peter Anvin wrote:
> > +#ifdef CONFIG_CMDLINE_BOOL
> > + strlcpy(saved_command_line, CONFIG_CMDLINE, COMMAND_LINE_SIZE);
> > +#endif
> > +
> > /* Save unparsed command line copy for /proc/cmdline */
> > saved_command_line[COMMAND_LINE_SIZE-1] = '\0';
> >
>
> NAK.
>
> a. Please make the patch available for x86-64 as well as x86. The two
> are coupled enough that they need to agree.
>
> b. This patch will override a user-provided command line if one
> exists. This is the wrong behaviour; instead, the builtin command
> line should only apply if no user-specified command line is present.
I would say a user supplied cmd line should be appended to the
built-in cmd line.
--
Greetings Michael.
next prev parent reply other threads:[~2006-06-12 17:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 21:55 [PATCH] x86 built-in command line Matt Mackall
2006-06-11 22:54 ` Jesper Juhl
2006-06-11 23:30 ` Jan Engelhardt
2006-06-11 23:47 ` Matt Mackall
2006-06-12 17:14 ` H. Peter Anvin
2006-06-11 23:40 ` Arjan van de Ven
2006-06-11 23:51 ` Matt Mackall
2006-06-12 0:08 ` Arjan van de Ven
2006-06-12 1:38 ` Matt Mackall
2006-06-12 5:13 ` Willy Tarreau
2006-06-12 17:15 ` H. Peter Anvin
2006-06-12 8:11 ` Andi Kleen
2006-06-12 14:37 ` Matt Mackall
2006-06-12 17:18 ` H. Peter Anvin
2006-06-12 17:12 ` H. Peter Anvin
2006-06-12 17:36 ` Michael Buesch [this message]
2006-06-12 17:52 ` H. Peter Anvin
2006-06-12 17:59 ` Tim Bird
[not found] ` <200606121712.k5CHClUE017185@terminus.zytor.com>
2006-06-12 20:49 ` Matt Mackall
2006-06-12 21:19 ` Thomas Gleixner
2006-06-12 21:36 ` Tim Bird
2006-06-12 21:45 ` Thomas Gleixner
2006-06-12 22:03 ` Tim Bird
2006-06-12 21:45 ` Randy.Dunlap
2006-06-12 22:00 ` Tim Bird
2006-06-12 22:10 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606121936.35042.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.