From: Stephen Hemminger <shemminger@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linus@osdl.org, netdev@vger.kernel.org
Subject: [RFT 2/5] sky2: suspend/resume patchlets
Date: Tue, 13 Jun 2006 17:17:28 +0900 [thread overview]
Message-ID: <20060613081930.370601000@localhost.localdomain> (raw)
In-Reply-To: 20060613081726.695812000@localhost.localdomain
[-- Attachment #1: sky2-ports.patch --]
[-- Type: text/plain, Size: 761 bytes --]
Subject: [RFT 2/5] sky2: don't hard code number of ports
It is cleaner, to not loop over both ports if only one exists.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- test.orig/drivers/net/sky2.c
+++ test/drivers/net/sky2.c
@@ -3430,7 +3430,7 @@ static int sky2_suspend(struct pci_dev *
if (!(pstate == PCI_D3hot || pstate == PCI_D3cold))
return -EINVAL;
- for (i = 0; i < 2; i++) {
+ for (i = 0; i < hw->ports; i++) {
struct net_device *dev = hw->dev[i];
if (dev) {
@@ -3460,7 +3460,7 @@ static int sky2_resume(struct pci_dev *p
if (err)
goto out;
- for (i = 0; i < 2; i++) {
+ for (i = 0; i < hw->ports; i++) {
struct net_device *dev = hw->dev[i];
if (dev && netif_running(dev)) {
netif_device_attach(dev);
--
next prev parent reply other threads:[~2006-06-13 8:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-13 8:17 [RFT 0/5] sky2: suspend/resume patchlets Stephen Hemminger
2006-06-13 8:17 ` [RFT 1/5] " Stephen Hemminger
2006-06-13 8:17 ` Stephen Hemminger [this message]
2006-06-13 8:17 ` [RFT 3/5] " Stephen Hemminger
2006-06-13 8:17 ` [RFT 4/5] " Stephen Hemminger
2006-06-13 8:17 ` [RFT 5/5] " Stephen Hemminger
2006-06-13 13:22 ` [RFT 0/5] " Jeff Garzik
2006-06-13 16:38 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060613081930.370601000@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linus@osdl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.