From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1FqDCv-0003MW-PW
	for mharc-grub-devel@gnu.org; Tue, 13 Jun 2006 14:01:41 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1FqDCu-0003Kv-Pr
	for grub-devel@gnu.org; Tue, 13 Jun 2006 14:01:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1FqDCs-0003Kf-Rf
	for grub-devel@gnu.org; Tue, 13 Jun 2006 14:01:40 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1FqDCs-0003Kc-Nh
	for grub-devel@gnu.org; Tue, 13 Jun 2006 14:01:38 -0400
Received: from [212.85.152.101] (helo=kotoba.storever.com)
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1FqDLs-0003ha-9i
	for grub-devel@gnu.org; Tue, 13 Jun 2006 14:10:56 -0400
Received: from kotoba.oasis.nexedi.com (kotoba.oasis.nexedi.com
	[212.85.152.101])
	by kotoba.storever.com (Postfix) with ESMTP id CCD633CD149E6
	for <grub-devel@gnu.org>; Tue, 13 Jun 2006 21:41:54 +0200 (CEST)
Received: from [??1] (localhost [127.0.0.1])
	by kotoba.storever.com (Postfix) with ESMTP id 5AB913CD149DB
	for <grub-devel@gnu.org>; Tue, 13 Jun 2006 21:41:54 +0200 (CEST)
From: "Yoshinori K. Okuji" <okuji@enbug.org>
Organization: enbug.org
To: The development of GRUB 2 <grub-devel@gnu.org>
Date: Tue, 13 Jun 2006 20:01:33 +0200
User-Agent: KMail/1.8.2
References: <868xo2tmpl.fsf@baz.foobar-qux.org>
In-Reply-To: <868xo2tmpl.fsf@baz.foobar-qux.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200606132001.34248.okuji@enbug.org>
X-Bogosity: No, tests=bogofilter, spamicity=0.492716, version=0.17.2
Subject: Re: Patch for successful compilation on FreeBSD Release-6.1
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jun 2006 18:01:41 -0000

On Monday 12 June 2006 17:31, Harley D. Eades III wrote:
> --- grub2/configure.ac  Sun Jun 11 17:49:23 2006
> +++ grub2Hacked/configure.ac    Sun Jun 11 17:55:34 2006
> @@ -121,6 +121,15 @@
>  AC_CHECK_SIZEOF(void *)
>  AC_CHECK_SIZEOF(long)
>
> +# BSD checks.
> +AC_CHECK_HEADER([malloc.h],
> +               [AC_DEFINE(HAVE_MALLOC_H, [],
> +               [Define to 1 if you have the malloc.h header file.])],
> ,)
> +

Please use AC_CHECK_HEADERS instead. Usually, you don't have to use 
AC_CHECK_HEADER. See the autoconf manual for more details.

> +AC_CHECK_FUNC([memalign],
> +             [AC_DEFINE(HAVE_MEMALIGN, [],
> +             [Define to 1 if you have the memalign function.])], ,)
> +

Likewise, please use AC_CHECK_FUNCS instead.

> --- grub2/include/grub/util/misc.h      Mon Feb 14 18:07:01 2005
> +++ grub2Hacked/include/grub/util/misc.h        Mon Jun  5 15:25:38
> 2006
> @@ -23,6 +23,7 @@
>  #include <stdlib.h>
>  #include <stdio.h>
>  #include <setjmp.h>
> +#include <unistd.h>

Can you tell me why it is necessary to include unistd.h here?

> --- grub2/util/grub-emu.c       Wed Apr 26 16:58:36 2006
> +++ grub2Hacked/util/grub-emu.c Mon Jun  5 15:26:30 2006
> @@ -18,7 +18,11 @@
>   */
>
>  #include <stdlib.h>
> +
> +#ifdef HAVE_MALLOC_H
>  #include <malloc.h>
> +#endif
> +

I don't know why it is necessary to include malloc.h. IIRC, FreeBSD does not 
use malloc.h since 4.2 or something. In fact, other projects, such as KDE, 
stop including malloc.h in all platforms. Can you elaborate on this change?

Thanks,
Okuji