From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] PATCH- i2c-iop3xx platform driver avoid addressing
Date: Sun, 18 Jun 2006 09:23:21 +0000 [thread overview]
Message-ID: <20060618112321.c9beb689.khali@linux-fr.org> (raw)
In-Reply-To: <44931779.6050302@d-tacq.com>
Hi Peter,
> Avoid addressing self when sending a Master address. Follows instruction
> in Intel 80331/80321 manuals.
> Ignoring this worked previously on 80321, but causes a hang on i2cdetect
> on 80331
Can't you simply disable the slave address? You don't seem to use it
anyway.
BTW, you must be using an old version of i2cdetect, as the slave address
appears to be forced to 0x02 in the i2c-iop3xx driver (not a smart
choice...) and i2cdetect does no more scan this address by default.
> diff -uprN -X dontdiff linux-2.6.16.20/drivers/i2c/busses/i2c-iop3xx.h linux-2.6.16.20-iq80331/drivers/i2c/busses/i2c-iop3xx.h
> --- linux-2.6.16.20/drivers/i2c/busses/i2c-iop3xx.h 2006-06-05 18:18:23.000000000 +0100
> +++ linux-2.6.16.20-iq80331/drivers/i2c/busses/i2c-iop3xx.h 2006-06-16 12:20:07.000000000 +0100
> @@ -85,6 +85,7 @@
> #define I2C_ERR 321
> #define I2C_ERR_BERR (I2C_ERR+0)
> #define I2C_ERR_ALD (I2C_ERR+1)
> +#define I2C_ERR_WRITEMYSAR (I2C_ERR+10)
Please use tabs, not spaces, for alignment.
--
Jean Delvare
next prev parent reply other threads:[~2006-06-18 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 20:41 [lm-sensors] PATCH- i2c-iop3xx platform driver avoid addressing self Peter Milne
2006-06-18 9:23 ` Jean Delvare [this message]
2006-06-18 15:54 ` [lm-sensors] PATCH- i2c-iop3xx platform driver avoid addressing Peter Milne
2006-06-18 18:45 ` Jean Delvare
2006-06-18 21:28 ` Peter Milne
2006-06-19 10:11 ` Jean Delvare
2006-06-19 12:17 ` Peter Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060618112321.c9beb689.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.