From: Joel Becker <Joel.Becker@oracle.com>
To: Christoph Hellwig <hch@infradead.org>,
Theodore Tso <tytso@thunk.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default
Date: Mon, 19 Jun 2006 09:16:51 -0700 [thread overview]
Message-ID: <20060619161651.GS29684@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20060619155821.GA27867@infradead.org>
On Mon, Jun 19, 2006 at 04:58:21PM +0100, Christoph Hellwig wrote:
> Blease don't add a field to the superblock for the optimal I/O size.
> Any filesystem that wants to override it can do so directly in ->getattr.
I don't disagree with you, but the idea of everyone implementing
->getattr where they just let it work before scares me. It's a ton of
cut-n-paste error waiting to happen. Especially if we make something
stale.
Perhaps add generic_fillattr_blksize()?
myfs_fillattr(inode, stat)
{
generic_fillattr_size(inode, myfavoriteblksize, stat)
}
Joel
--
Life's Little Instruction Book #407
"Every once in a while, take the scenic route."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2006-06-19 16:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 15:20 [RFC] [PATCH 0/8] Inode slimming Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Tso
2006-06-19 17:17 ` Jan Engelhardt
2006-06-19 19:09 ` Christoph Hellwig
2006-06-19 19:37 ` Theodore Tso
2006-06-20 9:43 ` Steven Whitehouse
2006-06-20 11:45 ` Arnd Bergmann
2006-06-20 12:34 ` Steven Whitehouse
2006-06-20 13:53 ` Arnd Bergmann
2006-06-20 15:01 ` Brian F. G. Bidulock
2006-06-20 15:04 ` Brian F. G. Bidulock
2006-06-20 12:29 ` Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 2/8] inode-diet: Move i_pipe into a union Theodore Tso
2006-06-19 17:19 ` Jan Engelhardt
2006-06-19 19:06 ` Theodore Tso
2006-06-20 15:23 ` Brian F. G. Bidulock
2006-06-21 1:45 ` Theodore Tso
2006-06-22 9:03 ` Brian F. G. Bidulock
2006-06-19 15:20 ` [RFC] [PATCH 3/8] inode-diet: Move i_bdev " Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 4/8] inode-diet: Move i_cdev " Theodore Tso
2006-06-19 17:20 ` Jan Engelhardt
2006-06-19 15:20 ` [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default Theodore Tso
2006-06-19 15:49 ` Avi Kivity
2006-06-19 16:55 ` Theodore Tso
2006-06-19 15:58 ` Christoph Hellwig
2006-06-19 16:16 ` Joel Becker [this message]
2006-06-19 17:20 ` Theodore Tso
2006-06-19 18:55 ` Christoph Hellwig
2006-06-19 22:13 ` Mark Fasheh
2006-06-21 19:41 ` Nate Diller
2006-06-19 17:03 ` Theodore Tso
2006-06-19 18:56 ` Christoph Hellwig
2006-06-19 16:01 ` Joel Becker
2006-06-19 17:06 ` Theodore Tso
2006-06-19 21:45 ` Joel Becker
2006-06-19 22:14 ` Mark Fasheh
2006-06-19 15:20 ` [RFC] [PATCH 6/8] inode-diet: Move i_cindex from struct inode to struct file Theodore Tso
2006-06-19 19:33 ` Al Viro
2006-06-19 19:37 ` Al Viro
2006-06-19 20:58 ` Theodore Tso
2006-06-19 21:51 ` Stefan Richter
2006-06-19 15:20 ` [RFC] [PATCH 7/8] inode-diet: Use a union for i_blocks and i_size, i_rdev and i_devices Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 8/8] inode-diet: Fix size of i_blkbits, i_version, and i_dnotify_mask Theodore Tso
2006-06-19 16:54 ` [RFC] [PATCH 0/8] Inode slimming Christoph Lameter
2006-06-19 19:09 ` Theodore Tso
-- strict thread matches above, loose matches on Subject: below --
2006-06-21 12:51 [RFC] [PATCH 0/8] Inode diet v2 Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619161651.GS29684@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@thunk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.