From: Phil Oester <kernel@linuxace.com>
To: netfilter-devel@lists.netfilter.org
Subject: [PATCH] REDIRECT does not accept IP
Date: Mon, 19 Jun 2006 18:22:08 -0700 [thread overview]
Message-ID: <20060620012208.GA17152@linuxace.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 181 bytes --]
As pointed out by Nicolas Mailhot in bugzilla #483, REDIRECT
does not accept an IP address and when supplied with one,
provides unexpected results. Patch below fixes this.
Phil
[-- Attachment #2: patch-redirect --]
[-- Type: text/plain, Size: 523 bytes --]
diff -ruN ipt-orig/extensions/libipt_REDIRECT.c ipt-new/extensions/libipt_REDIRECT.c
--- ipt-orig/extensions/libipt_REDIRECT.c 2005-07-21 23:39:45.000000000 -0700
+++ ipt-new/extensions/libipt_REDIRECT.c 2006-06-19 18:14:37.000000000 -0700
@@ -44,6 +44,9 @@
mr->range[0].flags |= IP_NAT_RANGE_PROTO_SPECIFIED;
+ if (strchr(arg, '.'))
+ exit_error(PARAMETER_PROBLEM, "IP address not permitted\n");
+
port = atoi(arg);
if (port == 0 || port > 65535)
exit_error(PARAMETER_PROBLEM, "Port `%s' not valid\n", arg);
next reply other threads:[~2006-06-20 1:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 1:22 Phil Oester [this message]
2006-06-20 13:21 ` [PATCH] REDIRECT does not accept IP Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620012208.GA17152@linuxace.com \
--to=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.