Re: 2.6.16.x CPUFREQ / SpeedStep-Centrino: couldn't enable Enchanced SpeedStep

[Bruno Ducrot <ducrot@poupinou.org>]

On Tue, Jun 20, 2006 at 11:43:57AM +0200, Bruno Ducrot wrote:
> On Mon, Jun 19, 2006 at 04:10:40PM -0700, Ben Kevan wrote:
> > Hi, 
> > 
> > I copied both on this because I thought you both may be interested. My problem 
> > is, my Toshiba Tecra M1 will only run at 598Mhz, and I can not use toshutils 
> > or anything else to configure speedstep to run higher. Or in any other way 
> > can I use it to run higher.  
> > 
> > Below are a bunch of commands to give you an idea of what's going on. Is this 
> > a bug with the 2.6.16.x build? Or is it something else that I am just 
> > oblivious too (ACPI?). 
> > 
> 
> ....
> 
> 
> > LSHESU01004839:/home/bkevan # cat /proc/cpuinfo
> > processor       : 0
> > vendor_id       : GenuineIntel
> > cpu family      : 6
> > model           : 9
> > model name      : Intel(R) Pentium(R) M processor 1600MHz
> > stepping        : 5
> > cpu MHz         : 598.582
> > cache size      : 1024 KB
> > fdiv_bug        : no
> > hlt_bug         : no
> > f00f_bug        : no
> > coma_bug        : no
> > fpu             : yes
> > fpu_exception   : yes
> > cpuid level     : 2
> > wp              : yes
> > flags           : fpu vme de pse tsc msr mce cx8 sep mtrr pge mca cmov pat 
> > clflush dts acpi mmx fxsr sse sse2 tm pbe est tm2
> > bogomips        : 1198.30
> 
> That's strange.  Even if there is no processor object declared onto ACPI
> tables it should work with CONFIG_X86_SPEEDSTEP_CENTRINO_TABLE set since
> it's a bania.
> 

I'm wondering if actually the bios correctly has been informed that the OS
take control of performance things (or something like such..)

(In that case, CONFIG_X86_SPEEDSTEP_CENTRINO_TABLE won't help, but it
may work with CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI set)

Could you please test with that little patch please ?


--- linux-2.6.17/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c	2006/06/20 10:09:38	1.1
+++ linux-2.6.17/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c	2006/06/20 10:11:03
@@ -455,7 +455,9 @@ static int centrino_cpu_init_acpi(struct
 	}
 
 	/* notify BIOS that we exist */
-	acpi_processor_notify_smm(THIS_MODULE);
+	result = acpi_processor_notify_smm(THIS_MODULE);
+	if (result)
+		printk(KERN_WARNING "notifying SMM bios failed\n");
 
 	return 0;
 

-- 
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.