From: Evgeniy Dushistov <dushistov@mail.ru>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/5]: ufs: missed brelse and wrong baseblk
Date: Tue, 20 Jun 2006 20:30:45 +0400 [thread overview]
Message-ID: <20060620163045.GA17903@rain.homenetwork> (raw)
In-Reply-To: <20060619191306.GK27946@ftp.linux.org.uk>
On Mon, Jun 19, 2006 at 08:13:06PM +0100, Al Viro wrote:
> Which is fsck-all protection, since then you proceed to do a lot of
> blocking operations. Now, lock_super() down in balloc.c _might_ be
> enough, but I wouldn't bet on that.
There is still leak of proper locking model for inode's metadata,
for example we don't lock/unlock buffer_head when check if
we've already allocated block or not,
so lock_kernel still necessary.
--
/Evgeniy
next prev parent reply other threads:[~2006-06-20 16:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-17 10:14 [PATCH 1/5]: ufs: missed brelse and wrong baseblk Evgeniy Dushistov
2006-06-18 16:20 ` Al Viro
2006-06-18 17:50 ` Al Viro
2006-06-19 6:47 ` Evgeniy Dushistov
2006-06-19 7:32 ` Al Viro
2006-06-19 13:17 ` Evgeniy Dushistov
2006-06-19 18:28 ` Al Viro
2006-06-19 18:58 ` Evgeniy Dushistov
2006-06-19 19:13 ` Al Viro
2006-06-20 16:30 ` Evgeniy Dushistov [this message]
2006-06-20 16:30 ` Evgeniy Dushistov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620163045.GA17903@rain.homenetwork \
--to=dushistov@mail.ru \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.