From: Theodore Tso <tytso@mit.edu>
To: linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private
Date: Wed, 21 Jun 2006 11:37:03 -0400 [thread overview]
Message-ID: <20060621153703.GA28159@thunk.org> (raw)
In-Reply-To: <20060621084408.C7834@openss7.org>
On Wed, Jun 21, 2006 at 08:44:08AM -0600, Brian F. G. Bidulock wrote:
> Theodore,
>
> On Wed, 21 Jun 2006, Theodore Tso wrote:
> >
> > static int remote_settings_file_open(struct inode *inode, struct file *file)
> > {
> > - file->private_data = inode->u.generic_ip;
> > + file->private_data = inode->i_private;
> > return 0;
> > }
> >
>
> I wish you would change private_data to f_private while your at it.
Different structure, different structure element, different patch.
- Ted
next prev parent reply other threads:[~2006-06-21 15:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 12:51 [RFC] [PATCH 0/8] Inode diet v2 Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Tso
2006-06-21 13:23 ` Jan Engelhardt
2006-06-21 14:44 ` Brian F. G. Bidulock
2006-06-21 15:37 ` Theodore Tso [this message]
2006-06-21 12:51 ` [RFC] [PATCH 2/8] inode-diet: Move i_pipe into a union Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 3/8] inode-diet: Move i_bdev " Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 4/8] inode-diet: Move i_cdev " Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 6/8] inode-diet: Move i_cindex from struct inode to struct file Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 7/8] inode-diet: Use a union for i_blocks and i_size, i_rdev and i_devices Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 8/8] inode-diet: Fix size of i_blkbits, i_version, and i_dnotify_mask Theodore Tso
[not found] ` <200606212335.00176.arnd@arndb.de>
2006-06-22 3:11 ` Theodore Tso
2006-06-21 14:42 ` [RFC] [PATCH 0/8] Inode diet v2 Brian F. G. Bidulock
2006-06-21 15:31 ` Nick Piggin
2006-06-21 16:06 ` Arjan van de Ven
2006-06-21 16:12 ` Brian F. G. Bidulock
2006-06-21 16:48 ` Theodore Tso
-- strict thread matches above, loose matches on Subject: below --
2006-06-19 15:20 [RFC] [PATCH 0/8] Inode slimming Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Tso
2006-06-19 17:17 ` Jan Engelhardt
2006-06-19 19:09 ` Christoph Hellwig
2006-06-19 19:37 ` Theodore Tso
2006-06-20 9:43 ` Steven Whitehouse
2006-06-20 11:45 ` Arnd Bergmann
2006-06-20 12:34 ` Steven Whitehouse
2006-06-20 13:53 ` Arnd Bergmann
2006-06-20 15:01 ` Brian F. G. Bidulock
2006-06-20 15:04 ` Brian F. G. Bidulock
2006-06-20 12:29 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060621153703.GA28159@thunk.org \
--to=tytso@mit.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.