From: Matthew Wilcox <matthew@wil.cx>
To: Douglas Gilbert <dougg@torque.net>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] Improve SCSI device type decoding
Date: Wed, 21 Jun 2006 12:48:42 -0600 [thread overview]
Message-ID: <20060621184842.GA1630@parisc-linux.org> (raw)
In-Reply-To: <449989BB.1010205@torque.net>
On Wed, Jun 21, 2006 at 02:02:35PM -0400, Douglas Gilbert wrote:
> Not forgetting peripheral device types 1eh and 1fh
> which are well known logical unit and unknown or
> no device type respectively.
I don't think you read the whole patch ;-)
+ if (type == 0x1e)
+ return "Well-known LUN ";
+ if (type > ARRAY_SIZE(scsi_device_types))
+ return "Unknown ";
Did you want to distinguish between a device of type unknown and a
device type Linux doesn't know about?
next prev parent reply other threads:[~2006-06-21 18:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 16:53 [PATCH 1/2] Improve SCSI device type decoding Matthew Wilcox
2006-06-21 17:14 ` [PATCH 2/2] Print SCSI Inquiry data more compactly Matthew Wilcox
2006-06-21 18:02 ` [PATCH 1/2] Improve SCSI device type decoding Douglas Gilbert
2006-06-21 18:48 ` Matthew Wilcox [this message]
2006-06-22 2:42 ` Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060621184842.GA1630@parisc-linux.org \
--to=matthew@wil.cx \
--cc=dougg@torque.net \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.