All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Dave Airlie <airlied@linux.ie>,
	ak@suse.de
Subject: Re: intelfb: enable on x86_64
Date: Thu, 22 Jun 2006 14:31:40 -0400	[thread overview]
Message-ID: <20060622183140.GB5604@redhat.com> (raw)
In-Reply-To: <20060622181849.GG21582@redhat.com>

On Thu, Jun 22, 2006 at 02:18:49PM -0400, Dave Jones wrote:

 > If you select for eg, IOMMU=y and CONFIG_AGP=y, and CONFIG_FB_INTEL=m,
 > then CONFIG_AGP gets silently turned into a =m, and the build fails with this..
 > 
 > arch/x86_64/kernel/pci-gart.c:619: undefined reference to `agp_amd64_init'
 > arch/x86_64/kernel/pci-gart.c:619: undefined reference to `agp_bridge'
 > arch/x86_64/kernel/pci-gart.c:619: undefined reference to `agp_copy_info'

This seems to work around it..

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6.17.noarch/drivers/video/Kconfig~	2006-06-22 14:27:13.000000000 -0400
+++ linux-2.6.17.noarch/drivers/video/Kconfig	2006-06-22 14:27:27.000000000 -0400
@@ -807,8 +807,8 @@ config FB_I810_I2C
 config FB_INTEL
 	tristate "Intel 830M/845G/852GM/855GM/865G support (EXPERIMENTAL)"
 	depends on FB && EXPERIMENTAL && PCI && X86 && !VGA_NOPROBE
-	select AGP
-	select AGP_INTEL
+	depends on AGP
+	depends on AGP_INTEL
 	select FB_MODE_HELPERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA

-- 
http://www.codemonkey.org.uk

      reply	other threads:[~2006-06-22 18:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200606200312.k5K3C0uC009812@hera.kernel.org>
2006-06-22 18:18 ` intelfb: enable on x86_64 Dave Jones
2006-06-22 18:31   ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060622183140.GB5604@redhat.com \
    --to=davej@redhat.com \
    --cc=airlied@linux.ie \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.