From: Dave Jones <davej@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
davej@codemonkey.org.uk, lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@osdl.org>
Subject: Re: [Ubuntu PATCH] cpufreq: fix powernow-k8 load bug
Date: Fri, 23 Jun 2006 08:28:45 -0400 [thread overview]
Message-ID: <20060623122845.GC19461@redhat.com> (raw)
In-Reply-To: <20060622203855.GD2959@openzaurus.ucw.cz>
On Thu, Jun 22, 2006 at 10:38:56PM +0200, Pavel Machek wrote:
> > --- linux-2617-pv.orig/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> > +++ linux-2617-pv/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> > @@ -1008,7 +1008,7 @@ static int __cpuinit powernowk8_cpu_init
> > * an UP version, and is deprecated by AMD.
> > */
> >
> > - if ((num_online_cpus() != 1) || (num_possible_cpus() != 1)) {
> > + if ((num_online_cpus() != 1)) {
> > printk(KERN_ERR PFX "MP systems not supported by PSB BIOS structure\n");
> > kfree(data);
> > return -ENODEV;
> >
>
> Seems wrong to me... what if I boot, then hotplug second cpu?
We only run this code if powernow_k8_cpu_init_acpi() has failed,
which it should never do on an SMP system.
So, you get exactly the same behaviour, as expected.
You can't support >1 CPU with PSB.
The above patch makes sure things continue to work if you run
an SMP kernel on UP hardware.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-06-23 12:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 5:32 [Ubuntu PATCH] cpufreq: fix powernow-k8 load bug Randy Dunlap
2006-06-21 5:41 ` Dave Jones
2006-06-21 5:45 ` Dave Jones
2006-06-22 20:38 ` Pavel Machek
2006-06-23 12:28 ` Dave Jones [this message]
2006-06-23 12:46 ` Pavel Machek
2006-06-23 13:04 ` Dave Jones
2006-06-23 13:05 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623122845.GC19461@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.