From: Christoph Hellwig <hch@infradead.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
Linus Torvalds <torvalds@osdl.org>,
David Teigland <teigland@redhat.com>,
Patrick Caulfield <pcaulfie@redhat.com>,
Kevin Anderson <kanderso@redhat.com>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: GFS2 and DLM
Date: Fri, 23 Jun 2006 15:45:30 +0100 [thread overview]
Message-ID: <20060623144530.GA32291@infradead.org> (raw)
In-Reply-To: <44980064.6040306@yahoo.com.au>
> The part where you needed file_read_actor looks like pretty much a stright
> cut and paste from __generic_file_aio_read, which indicates that you might
> be exporting at the wrong level.
A definitive NACK to this export. All other filesystems manage to use
the generic file read code so GFS should do so aswell. And there's a technical
reason for not exporting aswell as the generic file read interface is far
too complicated already.
> Not sure about the tty_ export. Would it be better to make a generic
> printfish interface on top of it and also replace the interesting dquot.c
> gymnastics? (I don't know)
In fact neither gfs nor dquot should use it at all. The xfs quota code
is fine without this nonsense.
next prev parent reply other threads:[~2006-06-23 14:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 12:17 GFS2 and DLM Steven Whitehouse
2006-06-20 12:32 ` Nick Piggin
2006-06-20 12:47 ` Steven Whitehouse
2006-06-20 14:04 ` Nick Piggin
2006-06-20 15:40 ` Steven Whitehouse
2006-06-20 19:55 ` Andrew Morton
2006-06-21 11:20 ` Steven Whitehouse
2006-06-23 14:45 ` Christoph Hellwig [this message]
2006-06-26 21:03 ` Ingo Molnar
2006-06-27 7:52 ` Christoph Hellwig
2006-06-20 12:33 ` Christoph Hellwig
2006-06-20 12:55 ` Steven Whitehouse
2006-06-20 15:55 ` Ingo Molnar
2006-06-23 14:49 ` Christoph Hellwig
2006-06-23 20:46 ` Andrew Morton
2006-06-26 20:03 ` Ingo Molnar
2006-06-26 20:12 ` Arjan van de Ven
2006-06-27 7:08 ` Ingo Molnar
2006-06-27 6:33 ` Ingo Molnar
2006-06-27 6:43 ` Arjan van de Ven
2006-06-27 7:07 ` Ingo Molnar
2006-06-27 7:06 ` Andrew Morton
2006-06-27 8:35 ` Ingo Molnar
2006-06-27 8:50 ` Andrew Morton
2006-06-27 9:04 ` Ingo Molnar
2006-06-27 9:23 ` Andrew Morton
2006-07-03 13:40 ` Steven Whitehouse
2006-06-27 8:16 ` Nathan Scott
2006-06-27 8:22 ` Ingo Molnar
2006-06-27 8:41 ` Pekka Enberg
2006-06-27 10:33 ` Ingo Molnar
2006-06-27 8:42 ` Nathan Scott
2006-06-27 8:51 ` Ingo Molnar
2006-06-23 14:54 ` Christoph Hellwig
2006-06-23 15:54 ` Steven Whitehouse
2006-06-23 15:54 ` Christoph Hellwig
2006-06-23 16:09 ` Steven Whitehouse
2006-06-23 14:55 ` Christoph Hellwig
2006-06-23 14:57 ` Christoph Hellwig
2006-06-23 15:26 ` Steven Whitehouse
2006-06-23 15:00 ` Christoph Hellwig
2006-06-23 16:29 ` Steven Whitehouse
2006-06-23 16:48 ` Christoph Hellwig
2006-06-26 20:58 ` Ingo Molnar
2006-06-27 7:50 ` Christoph Hellwig
2006-06-27 8:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623144530.GA32291@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=kanderso@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pcaulfie@redhat.com \
--cc=swhiteho@redhat.com \
--cc=teigland@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.