From: Timo Hirvonen <tihirvon@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: junkio@cox.net, git@vger.kernel.org
Subject: Re: [PATCH 0/5] Rework diff options
Date: Sat, 24 Jun 2006 01:44:20 +0300 [thread overview]
Message-ID: <20060624014420.2c3df276.tihirvon@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.63.0606240024460.29667@wbgn013.biozentrum.uni-wuerzburg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Sat, 24 Jun 2006, Timo Hirvonen wrote:
>
> > This patch series cleans up diff output format options.
>
> Very good.
>
> Although I understand that to convert all users to the new convention, it
> is sensible to rename the constants, I think it is not good to change
> something as DIFF_FORMAT_RAW to OUTPUT_FMT_RAW in the resulting patch.
>
> IMHO it is an unnecessary change, and accounts for a lot of the diffstat.
I did it because you can't have many DIFF_FORMAT_* options at the same
time but OUTPUT_FMT_* can be combined.
--
http://onion.dynserv.net/~timo/
next prev parent reply other threads:[~2006-06-23 22:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 22:15 [PATCH 0/5] Rework diff options Timo Hirvonen
2006-06-23 22:28 ` Johannes Schindelin
2006-06-23 22:44 ` Timo Hirvonen [this message]
2006-06-23 23:18 ` Johannes Schindelin
2006-06-23 23:28 ` Junio C Hamano
2006-06-24 0:04 ` Johannes Schindelin
2006-06-24 2:51 ` Junio C Hamano
2006-06-23 23:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060624014420.2c3df276.tihirvon@gmail.com \
--to=tihirvon@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.