From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@engr.sgi.com>,
Ravikiran G Thirumalai <kiran@scalex86.org>
Cc: linux-kernel@vger.kernel.org
Subject: remove __read_mostly?
Date: Sun, 25 Jun 2006 11:57:36 -0700 [thread overview]
Message-ID: <20060625115736.d90e1241.akpm@osdl.org> (raw)
I'm thinking we should remove __read_mostly.
Because if we use this everywhere where it's supposed to be used, we end up
with .bss and .data 100% populated with write-often variables, packed
closely together. The cachelines will really flying around.
IOW: __read_mostly optimises read-mostly variables and pessimises
write-often variables.
We want something which optimises both read-mostly and write-often storage.
We do that by marking the write-often variables with
__cacheline_aligned_in_smp.
OK?
[Problem is, I don't think any of the make-foo-__read_mostly patches
actually identified _which_ write-often variables were affecting `foo', so
we'll be back to square one.]
[Actually, we should do
#define __write_often __cacheline_aligned_in_smp
and use __write_often
a) for documentation and
b) so the optimisation can be centrally turned off, for space
optimisation or for performance validation.]
next reply other threads:[~2006-06-25 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 18:57 Andrew Morton [this message]
2006-06-25 21:19 ` remove __read_mostly? Ravikiran G Thirumalai
2006-06-26 18:39 ` Paul Jackson
2006-06-26 18:46 ` Christoph Lameter
2006-06-26 19:11 ` Paul Jackson
2006-06-26 19:52 ` Ravikiran G Thirumalai
2006-06-25 21:44 ` Arjan van de Ven
2006-06-26 4:20 ` Christoph Lameter
2006-06-25 21:52 ` Arjan van de Ven
2006-06-26 4:17 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060625115736.d90e1241.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.