From: Sam Ravnborg <sam@ravnborg.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Kconfig for radio cards to allow VIDEO_V4L1_COMPAT
Date: Sun, 25 Jun 2006 20:21:47 +0200 [thread overview]
Message-ID: <20060625182147.GA17945@mars.ravnborg.org> (raw)
In-Reply-To: <9e4733910606251040v62675399gdfe438aaac691a5a@mail.gmail.com>
On Sun, Jun 25, 2006 at 01:40:49PM -0400, Jon Smirl wrote:
> In Kconfig all of the radio cards depend on VIDEO_V4L1. But V4L1 has
> been deprecated and replaced with V4L2. V4L2 offers a V4L1
> compatibility layer. Should the Kconfig for these devices be changed
> to depend on (VIDEO_V4L1. || VIDEO_V4L1_COMPAT)? I'm not the
> maintainer for this but they seem to build ok.
A cleaner approach would be to define a local symbol that spelled out
the dependencies. Something like
# Used because ....
config RADIO
depends on ISA && (VIDEO_V4L1 || VIDEO_V4L1_COMPAT)
config RADIO_CADET
tristate "ADS Cadet AM/FM Tuner"
depends on RADIO
The variable name RADIO is awfully bad but you get the idea..
Sam
next prev parent reply other threads:[~2006-06-25 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 17:40 [PATCH] Kconfig for radio cards to allow VIDEO_V4L1_COMPAT Jon Smirl
2006-06-25 18:21 ` Sam Ravnborg [this message]
2006-06-25 19:48 ` Jon Smirl
2006-06-26 13:06 ` Mauro Carvalho Chehab
2006-06-26 15:55 ` Jon Smirl
2006-06-26 16:58 ` Mauro Carvalho Chehab
2006-06-26 17:15 ` Jon Smirl
2006-06-26 19:00 ` Mauro Carvalho Chehab
2006-07-30 23:40 ` Alan Cox
2006-07-31 21:28 ` Mauro Carvalho Chehab
2006-07-31 23:36 ` Alan Cox
2006-08-01 15:46 ` PATCH: Convert usb fm radio to V4L2 and move to the right directory Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060625182147.GA17945@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.