From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: netfilter-devel@lists.netfilter.org, Patrick McHardy <kaber@trash.net>
Subject: [NETFILTER 03/06]: xt_tcpudp: fix double unregistration in error path
Date: Mon, 26 Jun 2006 17:43:11 +0200 (MEST) [thread overview]
Message-ID: <20060626154311.11682.33519.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20060626154307.11682.28562.sendpatchset@localhost.localdomain>
[NETFILTER]: xt_tcpudp: fix double unregistration in error path
"xt_unregister_match(AF_INET, &tcp_matchstruct)" is called twice,
leaving "udp_matchstruct" registered, in case of a failure in the
registration of the udp6 structure.
Signed-off-by: Yuri Gushin <yuri@ecl-labs.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
commit a81302ac4c22da108602d0c053c168a700c81e32
tree b420da32ec06dd3d9e9a42b581bcfcc05b6eee53
parent 7cb7437f3a26e2054d315a9baea52f9d825a7286
author Yuri Gushin <yuri@ecl-labs.org> Mon, 19 Jun 2006 16:59:55 +0200
committer Patrick McHardy <kaber@trash.net> Mon, 19 Jun 2006 16:59:55 +0200
net/netfilter/xt_tcpudp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/netfilter/xt_tcpudp.c b/net/netfilter/xt_tcpudp.c
index 1b61dac..a9a63aa 100644
--- a/net/netfilter/xt_tcpudp.c
+++ b/net/netfilter/xt_tcpudp.c
@@ -260,7 +260,7 @@ static int __init xt_tcpudp_init(void)
return ret;
out_unreg_udp:
- xt_unregister_match(&tcp_matchstruct);
+ xt_unregister_match(&udp_matchstruct);
out_unreg_tcp6:
xt_unregister_match(&tcp6_matchstruct);
out_unreg_tcp:
next prev parent reply other threads:[~2006-06-26 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 15:43 [NETFILTER 00/06]: Netfilter Update Patrick McHardy
2006-06-26 15:43 ` [NETFILTER 01/06]: x_tables: fix xt_register_table error propagation Patrick McHardy
2006-06-26 15:43 ` [NETFILTER 02/06]: nf_conntrack: Fix undefined references to local_bh_* Patrick McHardy
2006-06-26 15:43 ` Patrick McHardy [this message]
2006-06-26 15:43 ` [NETFILTER 04/06]: xt_sctp: fix --chunk-types matching Patrick McHardy
2006-06-26 15:43 ` [NETFILTER 05/06]: ip_queue/nfnetlink_queue: drop bridge port references when dev disappears Patrick McHardy
2006-06-26 15:43 ` [NETFILTER 06/06]: statistic match: add missing Kconfig help text Patrick McHardy
2006-06-27 10:02 ` [NETFILTER 00/06]: Netfilter Update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626154311.11682.33519.sendpatchset@localhost.localdomain \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.