From: Benjamin LaHaise <bcrl@kvack.org>
To: akpm@osdl.org
Cc: jeff@garzik.org, netdev@vger.kernel.org, dan@scannet.dk,
dan@hacker.dk, jgarzik@pobox.com
Subject: Re: [patch 2/3] drivers/net/ns83820.c: add paramter to disable autonegotiation
Date: Mon, 26 Jun 2006 12:29:28 -0400 [thread overview]
Message-ID: <20060626162928.GA22614@kvack.org> (raw)
In-Reply-To: <200606250844.k5P8iasE020794@shell0.pdx.osdl.net>
On Sun, Jun 25, 2006 at 01:44:36AM -0700, akpm@osdl.org wrote:
>
> From: Dan Faerch <dan@scannet.dk>
>
> Adds "ethtool command" support to driver. Initially 2 commands are
> implemented: force fullduplex and toggle autoneg.
This part is good, although doing something for copper cards needs doing,
which probably means poking around to support the phy properly.
> Also added a "disable_autoneg" module argument to completely disable
> autoneg on all cards using this driver.
This is the part I disagree with. Are you sure it isn't a bug in the
link autonegotiation state machine for fibre cards? It should be defaulting
to 1Gbit/full duplex if no autonegotiation is happening, and if it isn't
then that should be fixed instead of papering over things with a config
option.
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@kvack.org>.
next prev parent reply other threads:[~2006-06-26 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-25 8:44 [patch 2/3] drivers/net/ns83820.c: add paramter to disable autonegotiation akpm
2006-06-26 16:29 ` Benjamin LaHaise [this message]
2006-06-27 11:43 ` Dan Faerch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626162928.GA22614@kvack.org \
--to=bcrl@kvack.org \
--cc=akpm@osdl.org \
--cc=dan@hacker.dk \
--cc=dan@scannet.dk \
--cc=jeff@garzik.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.