All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch
Date: Mon, 26 Jun 2006 21:30:27 +0000	[thread overview]
Message-ID: <20060626233027.0170262b.khali@linux-fr.org> (raw)
In-Reply-To: <449E7AD5.4060908@hhs.nl>

Hi Hans,

> Now that the abituguru driver is seeing some more widespread testing it
> has turned out that one the first generation of Abit uGuru motherboards,
> with uGuru revision 1, the autodetect bank1 sensor type code doesn't
> (always) work.
> 
> Thispatch adds a module param to override the autodetect, and it adds
> validity checks for the value of the 2 other autodetection override
> module params. An example of howto use the new param can be found here:
> http://lm-sensors.org/wiki/Configurations/Abit/AN7
> 
> It would be nice if this patch could be merged before 2.6.18, as without
> it the uguru driver is useless for people with the affected motherboards.

Fine with me, except for:

> --- linux-2.6.17-rc4-mm1.orig/drivers/hwmon/abituguru.c	2006-06-25 13:49:18.000000000 +0200
> +++ linux-2.6.17-rc4-mm1/drivers/hwmon/abituguru.c	2006-06-25 13:51:17.000000000 +0200
> @@ -142,6 +142,14 @@
>  static int force;
>  module_param(force, bool, 0);
>  MODULE_PARM_DESC(force, "Set to one to force detection.");
> +static int bank1_types[16] = { -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
> +	-1, -1, -1, -1 };

This "16" is actually ABIT_UGURU_MAX_BANK1_SENSORS, right?

> +module_param_array(bank1_types, int, NULL, 0);
> +MODULE_PARM_DESC(bank1_types, "Bank1 sensortype autodetection override:\n"
> +	"   -1 autodetect\n"
> +	"    0 volt sensor\n"
> +	"    1 temp sensor\n"
> +	"    2 not connected");

The "-1" is a detail implementation, user-space doesn't need to know
about it.

-- 
Jean Delvare


  parent reply	other threads:[~2006-06-26 21:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-25 12:00 [lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch Hans de Goede
2006-06-25 18:36 ` [lm-sensors] Patch: hwmon-abituguru-override-bank1detect-doc.patch Hans de Goede
2006-06-26 21:30 ` Jean Delvare [this message]
2006-06-27  6:37 ` [lm-sensors] Patch: hwmon-abituguru-override-bank1detect.patch Jean Delvare
2006-06-27 12:02 ` Hans de Goede
2006-06-28 12:12 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626233027.0170262b.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.