From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] whitespace in patches Q
Date: Tue, 27 Jun 2006 06:39:29 +0000 [thread overview]
Message-ID: <20060627083929.28193b26.khali@linux-fr.org> (raw)
In-Reply-To: <44A02463.1050504@gmail.com>
Hi Jim,
> I just went back over the patches on ticket #2076, looking for whitespace
> that might give heartburn to the reviewer; I found a few spots..
>
> cat -TE hwmon-pc87360-sysfs-combo-callbacks.patch |less
>
> In this chunk-frag, 2 leading tabs are conforming, but my editor adds spaces
> so that the code lines up inside the (open-paren). IMO thats an editor feature,
> and Doc/CodingStyle doesnt really speak to it, but its not clear that its an
> acceptable variation either.
>
> (that the spaces are present in the current code is *something*,
> but they were put there by me, and dont really prove much)
>
>
> static struct sensor_device_attribute_2 fan_min[] = {$
> ^ISENSOR_ATTR_2(fan1_min, S_IWUSR | S_IRUGO,$
> -^I^I show_fan_min, set_fan_min, FN_FAN_MIN, 0),$
> +^I^I show_fan, set_fan_min, FN_FAN_MIN, 0),$
> ^ISENSOR_ATTR_2(fan2_min, S_IWUSR | S_IRUGO,$
> -^I^I show_fan_min, set_fan_min, FN_FAN_MIN, 1),$
> +^I^I show_fan, set_fan_min, FN_FAN_MIN, 1),$
> ^ISENSOR_ATTR_2(fan3_min, S_IWUSR | S_IRUGO,$
> -^I^I show_fan_min, set_fan_min, FN_FAN_MIN, 2),$
> +^I^I show_fan, set_fan_min, FN_FAN_MIN, 2),$
> };$
Yes this is an acceptable variation, I have no problem with that.
--
Jean Delvare
prev parent reply other threads:[~2006-06-27 6:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 18:16 [lm-sensors] whitespace in patches Q Jim Cromie
2006-06-27 6:39 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060627083929.28193b26.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.