All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Restore set_nmi_callback export on x86_64
Date: Tue, 27 Jun 2006 17:50:27 +0200	[thread overview]
Message-ID: <200606271750.27899.ak@suse.de> (raw)
In-Reply-To: <20060627172418.84423784.khali@linux-fr.org>

On Tuesday 27 June 2006 17:24, Jean Delvare wrote:
> Commit 2ee60e17896c65da1df5780d3196c050bccb7d10 broke modular
> oprofile (amongst others I suspect) on x86_64 by killing the
> exports of set_nmi_callback and unset_nmi_callback. Let's
> restore the exports next to the functions as is prefered now.

Hmm yes this happened because I got unsubmitted patches 
that remove set_nmi_callback/unset_nmi_callback

But for 2.6.18 the patch is good, thanks.

-Andi

> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Andi Kleen <ak@suse.de>
> ---
>  arch/x86_64/kernel/nmi.c |    2 ++
>  1 files changed, 2 insertions(+)
> 
> --- linux-2.6.17-git.orig/arch/x86_64/kernel/nmi.c	2006-06-27 16:22:17.000000000 +0200
> +++ linux-2.6.17-git/arch/x86_64/kernel/nmi.c	2006-06-27 17:08:18.000000000 +0200
> @@ -607,11 +607,13 @@
>  	vmalloc_sync_all();
>  	rcu_assign_pointer(nmi_callback, callback);
>  }
> +EXPORT_SYMBOL_GPL(set_nmi_callback);
>  
>  void unset_nmi_callback(void)
>  {
>  	nmi_callback = dummy_nmi_callback;
>  }
> +EXPORT_SYMBOL_GPL(unset_nmi_callback);
>  
>  #ifdef CONFIG_SYSCTL
>  
> 
> 

      reply	other threads:[~2006-06-27 15:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-27 15:24 [PATCH] Restore set_nmi_callback export on x86_64 Jean Delvare
2006-06-27 15:50 ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606271750.27899.ak@suse.de \
    --to=ak@suse.de \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.