All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Habets <errandir_news@mph.eclipse.co.uk>
To: sparclinux@vger.kernel.org
Subject: [PATCH] sparc: remove sunzilog_console_init
Date: Wed, 28 Jun 2006 14:16:01 +0000	[thread overview]
Message-ID: <20060628141601.GA31139@palantir8> (raw)

Hi,

This patch against 2.6.17 resolves the following build warning:
  CC      drivers/serial/sunzilog.o
drivers/serial/sunzilog.c:1390: warning: `sunzilog_console_init' defined but not used

It was tested on a SS20 with the console on a sunzilog.

Martin

--- 2.6.17/drivers/serial/sunzilog.c.old	2006-06-28 15:04:17.000000000 +0100
+++ 2.6.17/drivers/serial/sunzilog.c	2006-06-28 15:07:43.000000000 +0100
@@ -1386,28 +1386,6 @@
 	.data   =	&sunzilog_reg,
 };
 
-static int __init sunzilog_console_init(void)
-{
-	int i;
-
-	if (con_is_present())
-		return 0;
-
-	for (i = 0; i < NUM_CHANNELS; i++) {
-		int this_minor = sunzilog_reg.minor + i;
-
-		if ((this_minor - 64) = (serial_console - 1))
-			break;
-	}
-	if (i = NUM_CHANNELS)
-		return 0;
-
-	sunzilog_console.index = i;
-	sunzilog_port_table[i].flags |= SUNZILOG_FLAG_IS_CONS;
-	register_console(&sunzilog_console);
-	return 0;
-}
-
 static inline struct console *SUNZILOG_CONSOLE(void)
 {
 	int i;
@@ -1432,7 +1410,6 @@
 
 #else
 #define SUNZILOG_CONSOLE()	(NULL)
-#define sunzilog_console_init() do { } while (0)
 #endif
 
 /*

             reply	other threads:[~2006-06-28 14:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 14:16 Martin Habets [this message]
2006-06-28 14:34 ` [PATCH] sparc: remove sunzilog_console_init Martin Habets
2006-06-28 16:43 ` Raymond Burns
2006-06-28 18:32 ` David Miller
2006-06-28 18:35 ` David Miller
2006-06-29 17:02 ` Martin Habets
2006-06-29 17:08 ` Martin Habets
2006-06-29 19:53 ` David Miller
2006-06-29 19:54 ` David Miller
2006-06-29 22:19 ` Raymond Burns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060628141601.GA31139@palantir8 \
    --to=errandir_news@mph.eclipse.co.uk \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.