From: Olof Johansson <olof@lixom.net>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org,
Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH] powerpc: support ibm,extended-*-frequency properties
Date: Thu, 29 Jun 2006 14:27:57 -0700 [thread overview]
Message-ID: <20060629212757.GA5093@pb15.lixom.net> (raw)
In-Reply-To: <0107ED1F-B674-48C3-AA07-BDF9FD2F7678@kernel.crashing.org>
On Tue, Jun 27, 2006 at 11:48:57PM -0500, Kumar Gala wrote:
> On Jun 20, 2006, at 3:47 AM, Anton Blanchard wrote:
> > + while (cells--)
> > + *val = (*val << 32) | *fp++;
>
> Is it reasonable for cells to be greater than 1 on a 32-bit system?
> If not, ok to protect this with a CONFIG_PPC64
Well, large values will be broken on 32-bit no matter what right now:
CC arch/powerpc/kernel/time.o
arch/powerpc/kernel/time.c: In function ‘get_freq’:
arch/powerpc/kernel/time.c:875: warning: left shift count >= width of type
-Olof
prev parent reply other threads:[~2006-06-29 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 8:47 [PATCH] powerpc: support ibm,extended-*-frequency properties Anton Blanchard
2006-06-20 9:50 ` Segher Boessenkool
2006-06-28 11:28 ` Anton Blanchard
2006-06-28 4:48 ` Kumar Gala
2006-06-28 11:15 ` Segher Boessenkool
2006-06-29 21:27 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060629212757.GA5093@pb15.lixom.net \
--to=olof@lixom.net \
--cc=anton@samba.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.