From: Dave Jones <davej@redhat.com>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: alexey.y.starikovskiy@intel.com,
cpufreq <cpufreq@www.linux.org.uk>,
Len Brown <lenb@unix-os.sc.intel.com>
Subject: Re: [PATCH 0/4] minor optimizations to ondemand governor
Date: Fri, 30 Jun 2006 01:06:33 -0400 [thread overview]
Message-ID: <20060630050633.GC32729@redhat.com> (raw)
In-Reply-To: <20060628134827.A12989@unix-os.sc.intel.com>
On Wed, Jun 28, 2006 at 01:48:27PM -0700, Venkatesh Pallipadi wrote:
>
> Patch series with optimizations to ondemand governor and some coding-style
> cleanups.
>
> [PATCH 1/4] minor optimizations to ondemand governor
> ondemand_remove_slowdown_06.patch
> Removes the slowdown option from ondemand governor. This simplifies code in
> periodic sampling a lot and reduces the path length in dbs_check_cpu
> by half.
>
> [PATCH 2/4] minor optimizations to ondemand governor
> queue_delayed_work_on_02.patch
> Add a new interface to workqueue to enable scheduling work on a particular CPU.
>
> [PATCH 3/4] minor optimizations to ondemand governor
> ondemand_percpu_06.patch
> Use queue_delayed_work_on interface to make ondemand sampling percpu. This also
> removes the mutex in sampling path.
>
> [PATCH 4/4] minor optimizations to ondemand governor
> ondemand_misc_cleanups_06.patch
> Misc. cleanups to ondemand from coding-style perspective.
Minor annoyance: Give the Subject: lines some more context,
as git uses them for short-log generation, and
[CPUFREQ] Remove the slowdown option from ondemand governor
[CPUFREQ] Add a new interface to workqueue to enable scheduling work on a particular CPU.
looks a bit more informative than
[CPUFREQ] [1/4] minor optimizations to ondemand governor
[CPUFREQ] [2/4] minor optimizations to ondemand governor
etc...
(I'll fix these up this time around, as they don't look like
they'll need much more work, and I need to make some minor edits anyway)
Other minor review comments follow:
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2006-06-30 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 20:48 [PATCH 0/4] minor optimizations to ondemand governor Venkatesh Pallipadi
2006-06-30 5:06 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060630050633.GC32729@redhat.com \
--to=davej@redhat.com \
--cc=alexey.y.starikovskiy@intel.com \
--cc=cpufreq@www.linux.org.uk \
--cc=lenb@unix-os.sc.intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.