* [KJ] entry in TODO List
@ 2006-06-30 9:43 Christophe Lucas
0 siblings, 0 replies; only message in thread
From: Christophe Lucas @ 2006-06-30 9:43 UTC (permalink / raw)
To: kernel-janitors
Hi,
Sorry if it is a mistake: but do we must do the same work on
- Use dev_set_drvdata to set dev->driver_data
...
as :
- Use pci_set_drvdata() to set dev->driver_data, likewise use
pci_get_drvdata()
instead of reading directly.
- dev->driver_data = pcigame;
+ pci_set_drvdata(dev, pcigame);
Few words more act... Does this patch is correct ?
Index: linux-2.6.17.2/drivers/net/tulip/de4x5.c
=================================--- linux-2.6.17.2.orig/drivers/net/tulip/de4x5.c 2006-06-30 11:41:37.000000000 +0200
+++ linux-2.6.17.2/drivers/net/tulip/de4x5.c 2006-06-30 11:42:38.000000000 +0200
@@ -1090,7 +1090,7 @@
struct pci_dev *pdev = NULL;
int i, status=0;
- gendev->driver_data = dev;
+ dev_set_drvdata(gendev, dev);
/* Ensure we're not sleeping */
if (lp->bus = EISA) {
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-30 9:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-30 9:43 [KJ] entry in TODO List Christophe Lucas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.