From: Chris Mason <mason@suse.com>
To: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: reiserfs-list@namesys.com, reiser@namesys.com,
reiserfs-dev@namesys.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] reiserfs:fix journaling issue regarding fsync()
Date: Sat, 1 Jul 2006 15:34:21 -0400 [thread overview]
Message-ID: <200607011534.24157.mason@suse.com> (raw)
In-Reply-To: <56260.61.127.129.98.1151708358.squirrel@serv1.oss.ntt.co.jp>
On Friday 30 June 2006 18:59, Hisashi Hifumi wrote:
> Hi.
>
> > This is correct, excpet you need to put the update_inode_transaction call
> > inside reiserfs_write_lock/unlock.
>
> Again, I remade my patch.
Thanks, this one looks good.
> I have a question.
> I understand update_inode_transaction must be inside reiserfs_write_lock.
> Is update_inode_transaction needed to be inside journal_begin/end ?
reiserfs_write_lock is enough, do_journal_end has reiserfs_write_lock while it
is updating j_current_jl and j_trans_id. We just need to make sure the
transid and the jl pointer are consistent with each other.
-chris
next prev parent reply other threads:[~2006-07-01 19:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 8:43 [PATCH] reiserfs:fix journaling issue regarding fsync() Hisashi Hifumi
2006-06-23 10:15 ` Vladimir V. Saveliev
2006-06-23 15:53 ` Hans Reiser
2006-06-26 4:39 ` Hisashi Hifumi
2006-06-30 0:47 ` Chris Mason
2006-06-30 1:36 ` Hisashi Hifumi
2006-06-30 12:24 ` Chris Mason
2006-06-30 22:59 ` Hisashi Hifumi
2006-07-01 19:34 ` Chris Mason [this message]
2006-07-02 15:34 ` Hans Reiser
2006-07-03 1:31 ` Hisashi Hifumi
2006-07-03 1:36 ` Andrew Morton
2006-07-03 2:03 ` Hisashi Hifumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607011534.24157.mason@suse.com \
--to=mason@suse.com \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=reiser@namesys.com \
--cc=reiserfs-dev@namesys.com \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.