All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Andrew Morton <akpm@osdl.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"Randy.Dunlap" <rdunlap@xenotime.net>,
	erik_frederiksen@pmc-sierra.com, linux-kernel@vger.kernel.org
Subject: Re: IS_ERR Threshold Value
Date: Sun, 2 Jul 2006 17:15:20 +0100	[thread overview]
Message-ID: <20060702161520.GA15791@linux-mips.org> (raw)
In-Reply-To: <44A6F5E3.8000300@zytor.com>

So MAX_ERRNO of EMAXERRNO which was also being used in assembler code.
Other architectures may have the same issue, so I propose wrapping the
C parts with #ifndef __ASSEMBLY__ to keep as happy.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/include/linux/err.h b/include/linux/err.h
index cd3b367..1ab1d44 100644
--- a/include/linux/err.h
+++ b/include/linux/err.h
@@ -15,6 +15,8 @@ #include <asm/errno.h>
  */
 #define MAX_ERRNO	4095
 
+#ifndef __ASSEMBLY__
+
 #define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
 
 static inline void *ERR_PTR(long error)
@@ -32,4 +34,6 @@ static inline long IS_ERR(const void *pt
 	return IS_ERR_VALUE((unsigned long)ptr);
 }
 
+#endif
+
 #endif /* _LINUX_ERR_H */

  reply	other threads:[~2006-07-02 17:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 20:57 IS_ERR Threshold Value Erik Frederiksen
2006-06-28 21:08 ` Randy.Dunlap
2006-06-28 22:39   ` H. Peter Anvin
2006-06-29 18:10   ` Ralf Baechle
2006-07-01 18:44     ` Randy.Dunlap
2006-07-01 22:23       ` H. Peter Anvin
2006-07-02 16:15         ` Ralf Baechle [this message]
2006-07-02 17:40           ` H. Peter Anvin
2006-07-02 18:22           ` Randy.Dunlap
2006-07-02 18:27         ` [PATCH] consistently use MAX_ERRNO in __syscall_return Randy.Dunlap
2006-07-03  7:39           ` Andrew Morton
2006-07-03 15:03             ` H. Peter Anvin
2006-07-03 15:42               ` Randy.Dunlap
2006-07-03 16:09                 ` H. Peter Anvin
2006-10-16 19:31     ` IS_ERR Threshold Value Andreas Mohr
2006-10-18 12:47       ` Jan Engelhardt
2006-06-28 22:41 ` Nathan Scott
2006-06-28 23:13   ` Erik Frederiksen
2006-06-28 23:22     ` Randy.Dunlap
2006-06-28 23:23     ` Nathan Scott
     [not found] <6sPiW-295-5@gated-at.bofh.it>
     [not found] ` <6sPsw-2y4-19@gated-at.bofh.it>
     [not found]   ` <6t9hu-6l6-11@gated-at.bofh.it>
     [not found]     ` <76GtI-T6-21@gated-at.bofh.it>
     [not found]       ` <77jbT-1y3-29@gated-at.bofh.it>
2006-10-18 23:29         ` Bodo Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060702161520.GA15791@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=akpm@osdl.org \
    --cc=erik_frederiksen@pmc-sierra.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.