From: Ingo Molnar <mingo@elte.hu>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, rmk+lkml@arm.linux.org.uk,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] genirq: ARM dyntick cleanup
Date: Mon, 3 Jul 2006 08:57:35 +0200 [thread overview]
Message-ID: <20060703065735.GA19780@elte.hu> (raw)
In-Reply-To: <1151908178.24611.39.camel@localhost.localdomain>
* Thomas Gleixner <tglx@linutronix.de> wrote:
> > btw, is this, from include/linux/irq.h:
> >
> > /*
> > * Please do not include this file in generic code. There is currently
> > * no requirement for any architecture to implement anything held
> > * within this file.
> > *
> > * Thanks. --rmk
> > */
> >
> > still true?
>
> I think what it means is that linux/irq.h must not be included in
> drivers. drivers should include linux/interrupt.h instead.
Christoph has had ideas for cleanups in the irq-header-files area for a
long time. My rough battleplan would be this:
- linux/interrupt.h should remain the highlevel driver API [which can be
used by both physical (genirq or non-genirq) or virtual platforms].
Only this file should be included by drivers.
- rename linux/irq.h to linux/irqchips.h, to make it less likely for
drivers to include it accidentally.
- rename asm/irq.h to asm/irqchips.h
- most of linux/hardirq.h should merge into interrupt.h [the rest into
linux/irqchips.h] and hardirq.h should be eliminated.
- merge asm/hardirq.h and asm/hw_irq.h into asm/irqchips.h.
Christoph, agreed?
Ingo
next prev parent reply other threads:[~2006-07-03 7:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 0:18 [PATCH] genirq: ARM dyntick cleanup Thomas Gleixner
2006-07-03 0:35 ` Andrew Morton
2006-07-03 6:29 ` Thomas Gleixner
2006-07-03 6:57 ` Ingo Molnar [this message]
2006-07-04 11:54 ` Christoph Hellwig
2006-07-04 12:22 ` Ingo Molnar
2006-07-05 8:35 ` Russell King
2006-07-08 18:53 ` Christoph Hellwig
2006-07-03 7:41 ` Russell King
2006-07-03 7:55 ` Andrew Morton
2006-07-03 9:03 ` Russell King
2006-07-03 9:12 ` Andrew Morton
2006-07-03 16:56 ` Linus Torvalds
2006-07-03 17:13 ` Linus Torvalds
2006-07-03 17:27 ` Arjan van de Ven
2006-07-05 23:24 ` Randy.Dunlap
2006-07-05 23:35 ` Andrew Morton
2006-07-05 23:50 ` Randy.Dunlap
2006-07-05 23:53 ` Linus Torvalds
2006-07-06 0:02 ` Randy.Dunlap
2006-07-06 6:47 ` Giacomo A. Catenazzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060703065735.GA19780@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.