All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Lucas <clucas@rotomalug.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 2] drivers/atm/idt77252.c: Fix more KERN_* in
Date: Mon, 03 Jul 2006 11:40:25 +0000	[thread overview]
Message-ID: <20060703114025.GG12211@rotomalug.org> (raw)
In-Reply-To: <44A83604.5090700@chello.nl>

Håkon Løvdal (hlovdal@gmail.com) wrote:
> On 03/07/06, Om Narasimhan <om.turyx@gmail.com> wrote:> On 7/3/06, Alexey Dobriyan <adobriyan@gmail.com> wrote:> > On Sun, Jul 02, 2006 at 11:09:24PM +0200, Richard wrote:> > >                       for (i = 16; i < 64; i++)> > > -                             printk(" %02x", queue->data[i]);> > > +                             printk("KERN_DEBUG %02x", queue->data[i]);> Shouldn't it be>             printk(KERN_DEBUG "%02x", queue->data[i]);> Note the `"`
> Yes but  the KERN_* constants should only be used at thebeginning of lines and this loop is printing something in themiddle, so in this case KERN_DEBUG should not be added.
> BR Håkon Løvdal

Please configure your MUA correctly (72 cars,...).

Have a nice day,

			 - Christophe -

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2006-07-03 11:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-02 18:57 [KJ] [PATCH 2] drivers/atm/idt77252.c: Fix more KERN_* in printk Richard
2006-07-02 22:28 ` [KJ] [PATCH 2] drivers/atm/idt77252.c: Fix more KERN_* in Alexey Dobriyan
2006-07-02 23:55 ` Om Narasimhan
2006-07-03 11:08 ` Håkon Løvdal
2006-07-03 11:40 ` Christophe Lucas [this message]
2006-07-03 22:00 ` Richard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060703114025.GG12211@rotomalug.org \
    --to=clucas@rotomalug.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.