From: Dave Jones <davej@redhat.com>
To: "Rafał Bilski" <rafalbilski@interia.pl>
Cc: cpufreq@lists.linux.org.uk
Subject: Re: [PATCH] Longhaul - There are limits
Date: Mon, 3 Jul 2006 10:11:48 -0400 [thread overview]
Message-ID: <20060703141148.GK14292@redhat.com> (raw)
In-Reply-To: <44A8A894.7020907@interia.pl>
On Mon, Jul 03, 2006 at 07:18:12AM +0200, Rafał Bilski wrote:
> Changes in Kconfig:
> 1. ACPI_PROCESSOR - next patch need ACPI C3 state working,
> 2. !X86_UP_APIC - (un)patched "longhaul" isn't APIC compatible,
> 3. !SMP - (un)patched "longhaul" isn't SMP compatible. First
> step would be APIC support. Second - per CPU private data.
>
> Signed-off-by: Rafał Bilski <rafalbilski@interia.pl>
>
> ---
>
> --- linux-2.6.17-git20/arch/i386/kernel/cpu/cpufreq/Kconfig.orig 2006-06-18 03:49:35.000000000 +0200
> +++ linux-2.6.17-git20/arch/i386/kernel/cpu/cpufreq/Kconfig 2006-07-02 19:48:40.000000000 +0200
> @@ -202,7 +202,7 @@ config X86_LONGRUN
> config X86_LONGHAUL
> tristate "VIA Cyrix III Longhaul"
> select CPU_FREQ_TABLE
> - depends on BROKEN
> + depends on !SMP && !X86_UP_APIC && ACPI_PROCESSOR
> help
> This adds the CPUFreq driver for VIA Samuel/CyrixIII,
> VIA Cyrix Samuel/C3, VIA Cyrix Ezra and VIA Cyrix Ezra-T
It's not unfeasible for an SMP kernel to be run on UP hardware,
(and several distros are shipping SMP kernels as default)
so I'm in two minds about removing the !SMP check, and making it be a
if (num_online_cpus() > 1)
return -ENODEV;
in the init routine.
Thoughts?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-07-03 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 5:18 [PATCH] Longhaul - There are limits Rafał Bilski
2006-07-03 14:11 ` Dave Jones [this message]
2006-07-03 16:00 ` Rafał Bilski
2006-07-03 16:52 ` Dave Jones
2006-07-03 17:39 ` Rafał Bilski
2006-07-03 18:37 ` Rafał Bilski
2006-07-03 19:14 ` Rafał Bilski
-- strict thread matches above, loose matches on Subject: below --
2006-07-04 15:50 Rafał Bilski
2006-07-06 19:46 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060703141148.GK14292@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@lists.linux.org.uk \
--cc=rafalbilski@interia.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.