From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vincent Hanquez Subject: Re: [PATCH] libxenstore should be executable Date: Tue, 4 Jul 2006 11:57:49 +0200 Message-ID: <20060704095749.GA6997@snarc.org> References: <1151983683.20228.25.camel@aglarond.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1151983683.20228.25.camel@aglarond.local> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Katz Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Jul 03, 2006 at 11:28:03PM -0400, Jeremy Katz wrote: > Shared libraries are supposed to be installed +x > > Signed-off-by: Jeremy Katz > > Jeremy > diff -r fd6d12935b56 tools/xenstore/Makefile > --- a/tools/xenstore/Makefile Mon Jul 03 16:07:20 2006 +0100 > +++ b/tools/xenstore/Makefile Mon Jul 03 23:26:44 2006 -0400 > @@ -171,7 +171,7 @@ install: all > $(INSTALL_PROG) xenstore-control $(DESTDIR)/usr/bin > $(INSTALL_PROG) xenstore-ls $(DESTDIR)/usr/bin > $(INSTALL_DIR) -p $(DESTDIR)/usr/$(LIBDIR) > - $(INSTALL_DATA) libxenstore.so $(DESTDIR)/usr/$(LIBDIR) > + $(INSTALL_PROG) libxenstore.so $(DESTDIR)/usr/$(LIBDIR) > $(INSTALL_DATA) xs.h $(DESTDIR)/usr/include > $(INSTALL_DATA) xs_lib.h $(DESTDIR)/usr/include I don't think that needed (almost all libraries in my /usr/lib are -x). Even then you shouldn't call INSTALL_**PROG** but just create an INSTALL_LIB or somethign similar.. -- Vincent Hanquez