All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] kernel-doc in drivers/base/core.c corrections
Date: Tue, 04 Jul 2006 22:25:20 +0000	[thread overview]
Message-ID: <20060704222520.GA25073@kroah.com> (raw)
In-Reply-To: <44AA5740.8050906@nachtwindheim.de>

On Tue, Jul 04, 2006 at 01:55:44PM +0200, Henne wrote:
> From: Henrik Kretzschmar <henne@nachtwindheim.de>
> 
> Corrects the kerneldocs for device_create() and device_destroy()
> with an eye on coding style and grammar.
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
> ---
> 
> --- linux-2.6.17-git22/drivers/base/core.c	2006-07-04 11:12:06.000000000 +0200
> +++ linux/drivers/base/core.c	2006-07-04 13:42:49.000000000 +0200
> @@ -559,9 +559,9 @@
> 
>  /**
>   * device_create - creates a device and registers it with sysfs
> - * @cs: pointer to the struct class that this device should be registered to.
> - * @parent: pointer to the parent struct device of this new device, if any.
> - * @dev: the dev_t for the char device to be added.
> + * @class: pointer to the struct class that this device should be registered to
> + * @parent: pointer to the parent struct device of this new device, if any
> + * @devt: the dev_t for the char device to be added
>   * @fmt: string for the class device's name

fmt should not say "class device's", but just "device's".

>   *
>   * This function can be used by char device classes.  A struct
> @@ -620,11 +620,11 @@
> 
>  /**
>   * device_destroy - removes a device that was created with device_create()
> - * @class: the pointer to the struct class that this device was registered * with.
> - * @dev: the dev_t of the device that was previously registered.
> + * @class: pointer to the struct class that this device was registered with
> + * @devt: the dev_t of the device that was previously registered
>   *
>   * This call unregisters and cleans up a class device that was created with a
> - * call to class_device_create()
> + * call to class_device_create().

Oops, no, this should say "device_create()", and drop the "class device"
and replace it with "device" earlier in the sentance.

That's what I get for cut-and-pasting this stuff, sorry.

Care to try it again?

thanks,

greg k-h
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2006-07-04 22:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-04 11:55 [KJ] [PATCH] kernel-doc in drivers/base/core.c corrections Henne
2006-07-04 22:25 ` Greg KH [this message]
2006-07-04 22:53 ` Henne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060704222520.GA25073@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.