From: Andrew Morton <akpm@osdl.org>
To: Dave Jones <davej@redhat.com>
Cc: dwmw2@infradead.org, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [CPUFREQ] Fix implicit declarations in ondemand.
Date: Wed, 5 Jul 2006 02:57:44 -0700 [thread overview]
Message-ID: <20060705025744.ea6ee5ed.akpm@osdl.org> (raw)
In-Reply-To: <20060705094657.GB1877@redhat.com>
On Wed, 5 Jul 2006 05:46:57 -0400
Dave Jones <davej@redhat.com> wrote:
> On Wed, Jul 05, 2006 at 10:43:05AM +0100, David Woodhouse wrote:
> > On Wed, 2006-07-05 at 02:36 -0700, Andrew Morton wrote:
> > > On Wed, 5 Jul 2006 05:22:54 -0400 Dave Jones <davej@redhat.com> wrote:
> > >
> > > > drivers/cpufreq/cpufreq_ondemand.c: In function ‘dbs_check_cpu’:
> > > > drivers/cpufreq/cpufreq_ondemand.c:238: error: implicit declaration
> > > of function ‘jiffies64_to_cputime64’
> > > > drivers/cpufreq/cpufreq_ondemand.c:239: error: implicit declaration
> > > of function ‘cputime64_sub’
> >
> > > > +#include <asm/cputime.h>
> >
> > > But kernel_stat.h already includes cputime.h, as does sched.h, and
> > > pretty much everything pulls in sched.h.
> > >
> > > It's not bad to avoid a dependency upon nested includes, but I do
> > > wonder how this error came about??
> >
> > asm-powerpc/cputime.h doesn't declare jiffies64_to_cputime64() or
> > cputime64_sub()
>
> The curious part is why it isn't picking up the definition from asm-generic
> like x86-64 & friends do.
>
CONFIG_VIRT_CPU_ACCOUNTING.
next prev parent reply other threads:[~2006-07-05 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 9:22 [CPUFREQ] Fix implicit declarations in ondemand Dave Jones
2006-07-05 9:36 ` Andrew Morton
2006-07-05 9:42 ` Dave Jones
2006-07-05 9:43 ` David Woodhouse
2006-07-05 9:46 ` Dave Jones
2006-07-05 9:57 ` Andrew Morton [this message]
2006-07-05 10:24 ` David Woodhouse
2006-07-05 23:09 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705025744.ea6ee5ed.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.