From: Martin Hicks <mort@bork.org>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: [PATCH] libata: PHY reset requires writing 0x4 to SControl
Date: Wed, 5 Jul 2006 15:06:13 -0400 [thread overview]
Message-ID: <20060705190613.GD16658@bork.org> (raw)
Hi,
Reading the Intel VSC and AHCI it seems like writing 0x302 is incorrect.
The only valid values are 4, 1 and 0. Writing 4 disables the
PHY.
Signed-off-by: Martin Hicks <mort@bork.org>
---
drivers/scsi/libata-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
99377743755ef015100ab52fd79ee950a783141b
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index 6c66877..577fbcc 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -2705,7 +2705,7 @@ int sata_std_hardreset(struct ata_port *
if ((rc = sata_scr_read(ap, SCR_CONTROL, &scontrol)))
return rc;
- scontrol = (scontrol & 0x0f0) | 0x302;
+ scontrol = (scontrol & 0x0f0) | 0x304;
if ((rc = sata_scr_write(ap, SCR_CONTROL, scontrol)))
return rc;
--
1.3.2
next reply other threads:[~2006-07-05 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 19:06 Martin Hicks [this message]
2006-07-05 19:11 ` [PATCH] libata: PHY reset requires writing 0x4 to SControl Martin Hicks
2006-07-16 3:27 ` Tejun Heo
2006-08-10 12:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705190613.GD16658@bork.org \
--to=mort@bork.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.