From: Andrew Morton <akpm@osdl.org>
To: Greg KH <greg@kroah.com>
Cc: tiwai@suse.de, arjan@infradead.org, kkeil@suse.de,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hisax fix usage of __init*
Date: Thu, 6 Jul 2006 12:22:50 -0700 [thread overview]
Message-ID: <20060706122250.34fdeded.akpm@osdl.org> (raw)
In-Reply-To: <20060706191129.GA20255@kroah.com>
On Thu, 6 Jul 2006 12:11:29 -0700
Greg KH <greg@kroah.com> wrote:
> > > Tips:
> > > The module_init()/module_exit() functions (and all initialization
> > > functions called only from these) should be marked __init/exit.
> > > The struct pci_driver shouldn't be marked with any of these tags.
> > > The ID table array should be marked __devinitdata.
>
> Yes, and that is correct. They should never be marked __initdata, as
> that is wrong for when CONFIG_HOTPLUG is enabled and the module is built
> in.
>
> So either use __devinitdata, or nothing (as it's only a memory savings
> if CONFIG_HOTPLUG is not enabled, which is real tough these days, and
> the driver is built into the system.)
I think the problem is that pci_driver has a pointer to the id_table. So
we have a ref to __devinitdata from .text.
That's runtimely-correct, but the new section checker could get offended.
next prev parent reply other threads:[~2006-07-06 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 11:23 [PATCH] hisax fix usage of __init* Karsten Keil
2006-07-05 11:37 ` Arjan van de Ven
2006-07-05 15:08 ` Takashi Iwai
2006-07-06 19:11 ` Greg KH
2006-07-06 19:22 ` Andrew Morton [this message]
2006-07-06 19:38 ` Greg KH
2006-07-06 20:22 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060706122250.34fdeded.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=greg@kroah.com \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.